Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CODEOWNERS and MAINTAINERS files #118

Merged
merged 4 commits into from
Feb 16, 2023

Conversation

toddysm
Copy link
Contributor

@toddysm toddysm commented Feb 8, 2023

Signed-off-by: Toddy Mladenov toddysm@gmail.com

This PR combines all the changes from the following PRs for updating the maintainers for notaryproject/notation-core-go sub-project:
Add Junjie Gao #114
Add Milind Gokarn #109
Add Patrick Zheng #113
Add Pritesh Bandi #110
Add Rakesh Gariganti #108
Add Shiwei Zhang #112

The proposal is to abandon the above PRs and merge only this one.

Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2023

Codecov Report

Merging #118 (e949feb) into main (78f2ec9) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #118   +/-   ##
=======================================
  Coverage   90.32%   90.32%           
=======================================
  Files          16       16           
  Lines        1457     1457           
=======================================
  Hits         1316     1316           
  Misses        110      110           
  Partials       31       31           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link

@vaninrao10 vaninrao10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Toddy Mladenov <toddysm@gmail.com>
@toddysm
Copy link
Contributor Author

toddysm commented Feb 8, 2023

Linking the issue #106

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but IANAM

Copy link

@patrickzheng200 patrickzheng200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but IANAM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but IANAM

Copy link

@NiazFK NiazFK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@gokarnm gokarnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but IANAM

Copy link
Contributor

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Welcome new maintainers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.