Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: add Gosec workflow #138

Closed
wants to merge 2 commits into from
Closed

Conversation

AdamKorcz
Copy link
Contributor

Adds a workflow for the Gosec static analysis tool and ignores false positive findings.

Signed-off-by: AdamKorcz <adam@adalogics.com>
@@ -100,7 +100,7 @@

// This will be flagged by the static code analyzer as 'Use of a weak cryptographic key' but its intentional
// and is used only for testing.
k, _ := rsa.GenerateKey(rand.Reader, 1024)
k, _ := rsa.GenerateKey(rand.Reader, 1024) // #nosec

Check failure

Code scanning / CodeQL

Use of a weak cryptographic key

The size of this RSA key should be at least 2048 bits.
priteshbandi
priteshbandi previously approved these changes Jun 5, 2023
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Pritesh Bandi <priteshbandi@gmail.com>
Signed-off-by: AdamKorcz <44787359+AdamKorcz@users.noreply.github.com>
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2023

Codecov Report

Merging #138 (cd8edc6) into main (010204d) will decrease coverage by 1.20%.
The diff coverage is 50.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
- Coverage   90.32%   89.13%   -1.20%     
==========================================
  Files          16       21       +5     
  Lines        1457     1693     +236     
==========================================
+ Hits         1316     1509     +193     
- Misses        110      149      +39     
- Partials       31       35       +4     
Impacted Files Coverage Δ
x509/key.go 0.00% <0.00%> (ø)
x509/cert.go 76.92% <100.00%> (ø)

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

- name: Checkout Source
uses: actions/checkout@v3
- name: Run Gosec Security Scanner
uses: securego/gosec@master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use a fixed version?

Copy link

This PR is stale because it has been opened for 45 days with no activity. Remove stale label or comment. Otherwise, it will be closed in 30 days.

@github-actions github-actions bot added the Stale label Mar 22, 2024
Copy link

PR closed due to no activity in the past 30 days.

@github-actions github-actions bot closed this Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants