fix: change OCSP hash and encoding #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
kody-kimberl
requested review from
gokarnm,
JeyJeyGao,
justincormack,
NiazFK,
patrickzheng200,
priteshbandi,
rgnote,
shizhMSFT and
SteveLasker
as code owners
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #141 +/- ##
==========================================
- Coverage 89.32% 89.13% -0.20%
==========================================
Files 21 21
Lines 1677 1693 +16
==========================================
+ Hits 1498 1509 +11
- Misses 142 149 +7
+ Partials 37 35 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shizhMSFT
requested changes
Apr 21, 2023
shizhMSFT
reviewed
Apr 21, 2023
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
shizhMSFT
reviewed
Apr 21, 2023
shizhMSFT
reviewed
Apr 21, 2023
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
Signed-off-by: Kody Kimberl <kody.kimberl.work@gmail.com>
Co-authored-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: Kody Kimberl <59657721+kody-kimberl@users.noreply.github.com>
patrickzheng200
approved these changes
Apr 21, 2023
There was a problem hiding this comment.
LGTM. Thanks @kody-kimberl! The logic looks much cleaner now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup fix to #134
After testing with real certificates, there are some discrepancies with what hashes are supported and the correct URL encoding.
The following do not support SHA256 hashes:
As this represents a large percentage of public CAs, we should change the hashing algorithm to SHA1, which has been confirmed to be supported by all that were tested.
Additionally, the base64 URL encoding was not actually escaping URL characters, resulting in malformed requests. We need to change it to StdEncoding and query escape it.
Signed-off-by: Kody Kimberl kody.kimberl.work@gmail.com