Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: shift Go support window to [1.20, 1.21] #162

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

Two-Hearts
Copy link
Contributor

Since go has released 1.21, moving the build window from [1.19, "1.20"] to ["1.20", "1.21"].

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2023

Codecov Report

Merging #162 (2d1b9bd) into main (0c1ec3b) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #162   +/-   ##
=======================================
  Coverage   89.13%   89.13%           
=======================================
  Files          21       21           
  Lines        1693     1693           
=======================================
  Hits         1509     1509           
  Misses        149      149           
  Partials       35       35           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT changed the title chore: update golang version build: shift Go support window to [1.20, 1.21] Aug 31, 2023
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit 1373ab0 into notaryproject:main Sep 4, 2023
7 checks passed
@Two-Hearts Two-Hearts deleted the update-go branch September 6, 2023 09:51
@shizhMSFT shizhMSFT mentioned this pull request Oct 19, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants