Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: CRL cache #216

Merged
merged 119 commits into from
Sep 20, 2024
Merged

feat: CRL cache #216

merged 119 commits into from
Sep 20, 2024
+1,017 −216

Conversation

JeyJeyGao
Copy link
Contributor

@JeyJeyGao JeyJeyGao commented Aug 1, 2024 •
edited
Loading

Feat:

  • added a Cache interface for CRL
  • added a Fetcher for fetching from the cache, downloading and setting the cache
    Test:
  • added unit test

@JeyJeyGao
Squashed commit of the following:
62aa8fc 
commit 9240650
Merge: 0c1ec3b 4198690
Author: Junjie Gao <junjiegao@microsoft.com>
Date:   Wed Aug 9 17:07:34 2023 +0800

    Merge pull request #1 from JeyJeyGao/feat/ans1

    feat: convert BER to DER

commit 4198690
Author: Junjie Gao <junjiegao@microsoft.com>
Date:   Wed Aug 9 09:14:29 2023 +0800

    fix: simplify code

    Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

commit 75ce02d
Author: Junjie Gao <junjiegao@microsoft.com>
Date:   Mon Aug 7 20:33:08 2023 +0800

    fix: added Conetent method for value interface

    Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

commit 7b823a9
Author: Junjie Gao <junjiegao@microsoft.com>
Date:   Mon Aug 7 08:54:37 2023 +0800

    fix: update code

    Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

commit 41ecec6
Author: Junjie Gao <junjiegao@microsoft.com>
Date:   Sun Aug 6 17:33:19 2023 +0800

    fix: remove recusive call for encode()

    Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

commit 8f1a2af
Author: Junjie Gao <junjiegao@microsoft.com>
Date:   Fri Aug 4 13:40:09 2023 +0800

    fix: remove unused value

    Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

commit 9b6a0c5
Author: Junjie Gao <junjiegao@microsoft.com>
Date:   Thu Aug 3 20:25:22 2023 +0800

    fix: update code

    Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

commit 91a3691
Author: Junjie Gao <junjiegao@microsoft.com>
Date:   Thu Aug 3 20:11:28 2023 +0800

    fix: create pointer instead of value to improve performance

    Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

commit 1465e3e
Author: Junjie Gao <junjiegao@microsoft.com>
Date:   Thu Aug 3 20:04:44 2023 +0800

    fix: update code

    Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

commit 6524a9c
Author: Junjie Gao <junjiegao@microsoft.com>
Date:   Thu Aug 3 19:53:27 2023 +0800

    fix: update variable naming

    Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

commit 6cfbd9c
Author: Junjie Gao <junjiegao@microsoft.com>
Date:   Thu Aug 3 19:47:39 2023 +0800

    fix: update code

    Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

commit b9c73bd
Author: Junjie Gao <junjiegao@microsoft.com>
Date:   Thu Aug 3 17:56:52 2023 +0800

    fix: update to use rawContent instead of expectedLen

    Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

commit 3c99402
Author: Junjie Gao <junjiegao@microsoft.com>
Date:   Thu Aug 3 16:45:09 2023 +0800

    fix: update comment

    Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

commit f4dc95f
Author: Junjie Gao <junjiegao@microsoft.com>
Date:   Thu Aug 3 16:41:57 2023 +0800

    fix: resolve comment

    Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

commit f916316
Author: Junjie Gao <junjiegao@microsoft.com>
Date:   Thu Aug 3 16:40:37 2023 +0800

    fix: update code

    Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

commit 22afdf8
Author: Junjie Gao <junjiegao@microsoft.com>
Date:   Thu Aug 3 16:34:34 2023 +0800

    fix: resolve comment

    Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

commit edb729c
Author: Junjie Gao <junjiegao@microsoft.com>
Date:   Thu Aug 3 16:32:47 2023 +0800

    fix: resolve comment

    Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

commit a8ba0ff
Author: Junjie Gao <junjiegao@microsoft.com>
Date:   Thu Aug 3 16:26:29 2023 +0800

    fix: update code

    Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

commit bc18cae
Author: Junjie Gao <junjiegao@microsoft.com>
Date:   Thu Aug 3 16:14:57 2023 +0800

    fix: resolve comments

    Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

commit 643f388
Author: Junjie Gao <junjiegao@microsoft.com>
Date:   Thu Aug 3 09:17:39 2023 +0800

    fix: update comment

    Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

commit b5d5131
Author: Junjie Gao <junjiegao@microsoft.com>
Date:   Thu Aug 3 09:15:23 2023 +0800

    fix: expectedLen == 0 should continue

    Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

commit 2345740
Author: Junjie Gao <junjiegao@microsoft.com>
Date:   Wed Aug 2 13:01:38 2023 +0800

    fix: added copyright

    Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

commit 936ba2b
Author: Junjie Gao <junjiegao@microsoft.com>
Date:   Wed Aug 2 11:36:02 2023 +0800

    fix: remove recusive decoding

    Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

commit 4fd944a
Author: Junjie Gao <junjiegao@microsoft.com>
Date:   Tue Aug 1 21:50:10 2023 +0800

    fix: remove readOnlySlice

    Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

commit efa7575
Author: Junjie Gao <junjiegao@microsoft.com>
Date:   Tue Aug 1 09:38:57 2023 +0800

    fix: update decodeIdentifier function name

    Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

commit cbce4c1
Author: Junjie Gao <junjiegao@microsoft.com>
Date:   Tue Aug 1 09:25:34 2023 +0800

    fix: update code

    Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

commit 45480e5
Author: Junjie Gao <junjiegao@microsoft.com>
Date:   Mon Jul 31 21:22:20 2023 +0800

    fix: update code

    Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

commit b3de155
Author: Junjie Gao <junjiegao@microsoft.com>
Date:   Mon Jul 31 20:51:48 2023 +0800

    fix: set non-exportable type

    Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

commit 5dea9e5
Author: Junjie Gao <junjiegao@microsoft.com>
Date:   Mon Jul 31 20:44:50 2023 +0800

    feat: asn.1 first version

    Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
test: add unit test
eef8579 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
feat: crl support
feb151c 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update
56da59c 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
Merge remote-tracking branch 'upstream/main' into feat/crl
7d869a7
@JeyJeyGao
fix: update
a25275e 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update crl
a262bab 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
Merge remote-tracking branch 'upstream/main' into feat/crl
7d591d6
@JeyJeyGao
fix: update cache
e66d9fd 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update
ac1d240 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
Merge remote-tracking branch 'upstream/main' into feat/crl
e789f29
@JeyJeyGao
fix: update test
31fa5a5 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update
039be39 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update
3b1a7ed 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update
6875035 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update
5bbd8c7 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: deprecate revocation Mode
39c94d3 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update
c85d472 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update
a8db155 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update
534d11e 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update
50964ba 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update
cf593b1 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update
c172845 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update
1aa53fd 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update
2d39c35 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update
4c01b9e 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: remove cache
5787e75 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update
41746fb 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: refactor
759b727 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update
17da500 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
shizhMSFT
shizhMSFT reviewed Sep 19, 2024
View reviewed changes
revocation/crl/fetcher.go Outdated Show resolved Hide resolved
revocation/crl/fetcher.go Outdated Show resolved Hide resolved
revocation/internal/crl/crl.go Outdated Show resolved Hide resolved
revocation/revocation.go Outdated Show resolved Hide resolved
@JeyJeyGao
fix: resolve comments
dae3a2a 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update
73c2958 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
shizhMSFT
shizhMSFT previously approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Two-Hearts
Two-Hearts reviewed Sep 19, 2024
View reviewed changes
revocation/crl/fetcher.go Outdated Show resolved Hide resolved
revocation/crl/fetcher.go Outdated Show resolved Hide resolved
revocation/crl/errors.go Outdated Show resolved Hide resolved
revocation/internal/crl/crl.go Outdated Show resolved Hide resolved
@JeyJeyGao
fix: resolve comments
7ed8899 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Two-Hearts
Two-Hearts previously approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT previously approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao JeyJeyGao mentioned this pull request Sep 20, 2024
Open
@JeyJeyGao
fix: added DiscardCacheError in fetcher
00e8bce 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao JeyJeyGao dismissed stale reviews from shizhMSFT and Two-Hearts via 00e8bce September 20, 2024 03:58
shizhMSFT
shizhMSFT reviewed Sep 20, 2024
View reviewed changes
revocation/crl/fetcher.go Outdated Show resolved Hide resolved
revocation/crl/fetcher.go Outdated Show resolved Hide resolved
@JeyJeyGao
fix: update
335d7d9 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update
cd5bbc0 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
test: update
f21a22e 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update
375867e 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update
6741002 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update
4b3bd0e 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
shizhMSFT
shizhMSFT approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Two-Hearts
Two-Hearts approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeyJeyGao JeyJeyGao merged commit 5d9b2ed into notaryproject:main Sep 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priteshbandi priteshbandi priteshbandi approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@Two-Hearts Two-Hearts Two-Hearts approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

@yizha1 yizha1 Awaiting requested review from yizha1 yizha1 is a code owner

@junczhu junczhu Awaiting requested review from junczhu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JeyJeyGao @priteshbandi @shizhMSFT @junczhu @Two-Hearts