Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delta CRL #247

Merged
merged 30 commits into from
Jan 21, 2025
Merged
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
e34370f
feat: delta CRL
JeyJeyGao Nov 26, 2024
8182be9
fix: license and variable names
JeyJeyGao Nov 26, 2024
2049193
fix: optimize logic
JeyJeyGao Nov 26, 2024
33d5590
fix: working on delta CRL
JeyJeyGao Nov 27, 2024
7984f57
fix: bug
JeyJeyGao Nov 27, 2024
77b5972
test: add test for fetcher
JeyJeyGao Nov 28, 2024
0b6179a
test: complete test for validate
JeyJeyGao Nov 28, 2024
c9f936f
test: add test cases
JeyJeyGao Nov 28, 2024
c228487
Merge branch 'main' into feat/delta_crl
JeyJeyGao Nov 28, 2024
483d298
fix: only support delta CRL url from base CRL
JeyJeyGao Dec 5, 2024
2910e31
fix: update
JeyJeyGao Dec 5, 2024
934698a
fix: improve code style
JeyJeyGao Dec 9, 2024
c506b40
Merge branch 'main' into feat/delta_crl
JeyJeyGao Dec 9, 2024
cc34d0d
fix: update
JeyJeyGao Dec 9, 2024
630c7a5
fix: simplify code
JeyJeyGao Dec 9, 2024
ad51cf8
fix: simplify code
JeyJeyGao Dec 9, 2024
a9330e5
fix: update
JeyJeyGao Dec 13, 2024
b2f2852
fix: optimize Fetch
JeyJeyGao Dec 13, 2024
1239c5c
fix: update
JeyJeyGao Dec 13, 2024
28069ee
fix: resolve comment for Shiwei
JeyJeyGao Dec 16, 2024
6becbe1
fix: update
JeyJeyGao Dec 16, 2024
43e6407
fix: resolve comments for Two-Hearts
JeyJeyGao Dec 23, 2024
52c48a8
fix: add license
JeyJeyGao Dec 23, 2024
0e5b4d0
fix: simplify code
JeyJeyGao Dec 24, 2024
dc3a62e
fix: test
JeyJeyGao Dec 24, 2024
9c5f919
fix: resolve comment for Shiwei
JeyJeyGao Dec 26, 2024
a24fe9d
fix: update comment
JeyJeyGao Dec 26, 2024
31bdd6a
Merge branch 'main' into feat/delta_crl
JeyJeyGao Jan 2, 2025
3de709f
Merge branch 'main' into feat/delta_crl
JeyJeyGao Jan 7, 2025
e49e0de
Merge branch 'main' into feat/delta_crl
JeyJeyGao Jan 14, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions revocation/internal/crl/crl.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ package crl
import (
"context"
"crypto/x509"
"crypto/x509/pkix"
"encoding/asn1"
"errors"
"fmt"
Expand Down Expand Up @@ -119,7 +118,7 @@ func CertCheckStatus(ctx context.Context, cert, issuer *x509.Certificate, opts C
serverResults = make([]*result.ServerResult, 0, len(cert.CRLDistributionPoints))
lastErr error
crlURL string
hasFreshestCRLInCertificate = hasFreshestCRL(cert.Extensions)
hasFreshestCRLInCertificate = x509util.FindExtensionByOID(oidFreshestCRL, cert.Extensions) != nil
)

// The CRLDistributionPoints contains the URIs of all the CRL distribution
Expand Down Expand Up @@ -200,10 +199,6 @@ func Supported(cert *x509.Certificate) bool {
return cert != nil && len(cert.CRLDistributionPoints) > 0
}

func hasFreshestCRL(extensions []pkix.Extension) bool {
return x509util.FindExtensionByOID(oidFreshestCRL, extensions) != nil
}

func validate(bundle *crl.Bundle, issuer *x509.Certificate) error {
// validate base CRL
baseCRL := bundle.BaseCRL
Expand Down
Loading