Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename signer to signature submodule #71

Merged

Conversation

binbin-li
Copy link
Contributor

What?

  1. Rename signer submodule to signature submodule.
  2. Update the package name accordingly.

Signed-off-by: Binbin Li libinbin@microsoft.com

Signed-off-by: Binbin Li <libinbin@microsoft.com>
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 56b3f7d into notaryproject:stage/cose Sep 9, 2022
shizhMSFT pushed a commit that referenced this pull request Sep 13, 2022
Signed-off-by: Binbin Li <libinbin@microsoft.com>
binbin-li added a commit that referenced this pull request Sep 13, 2022
Signed-off-by: Binbin Li <libinbin@microsoft.com>
shizhMSFT pushed a commit that referenced this pull request Sep 21, 2022
Signed-off-by: Binbin Li <libinbin@microsoft.com>
patrickzheng200 pushed a commit that referenced this pull request Sep 23, 2022
* Bump github.com/golang-jwt/jwt/v4 from 4.4.1 to 4.4.2 (#14)

Bumps [github.com/golang-jwt/jwt/v4](https://github.com/golang-jwt/jwt) from 4.4.1 to 4.4.2.
- [Release notes](https://github.com/golang-jwt/jwt/releases)
- [Changelog](https://github.com/golang-jwt/jwt/blob/main/VERSION_HISTORY.md)
- [Commits](golang-jwt/jwt@v4.4.1...v4.4.2)

---
updated-dependencies:
- dependency-name: github.com/golang-jwt/jwt/v4
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* refactor: refactor envelope and signer to support cose (#53)

Signed-off-by: Binbin Li <libinbin@microsoft.com>

* Revert "refactor: refactor envelope and signer to support cose (#53)" (#67)

This reverts commit cbea2cf.

Signed-off-by: Shiwei Zhang <shizh@microsoft.com>

* update to go 1.18 (#66)

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

* refactor: rename signer to signature submodule (#71)

Signed-off-by: Binbin Li <libinbin@microsoft.com>

* refactor: refactor envelope and signer to support cose (#73)

Signed-off-by: Binbin Li <libinbin@microsoft.com>

* feat: added COSE envelope implementation

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update per code review

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update per code review

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* update per code review

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* resolve conflicts

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated conformance test

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* refactor: JWS for signature package (#76)

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

* refactor: rename signer to signature submodule (#71)

Signed-off-by: Binbin Li <libinbin@microsoft.com>

* refactor: refactor envelope and signer to support cose (#73)

Signed-off-by: Binbin Li <libinbin@microsoft.com>

* refactor: JWS for signature package (#76)

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

* Allows signing with self-signed certificate (#77)

Signed-off-by: Pritesh Bandi <pritesb@amazon.com>

* updated conformance_test

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* refactor: refactor comments (#78)

Signed-off-by: Binbin Li <libinbin@microsoft.com>

* updated per code review

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* updated per code review

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* removed CLI related maps, they should be in notation CLI

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

* resolved conflicts

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Binbin Li <libinbin@microsoft.com>
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Binbin Li <libinbin050215@gmail.com>
Co-authored-by: Shiwei Zhang <shizh@microsoft.com>
Co-authored-by: Junjie Gao <43160897+JeyJeyGao@users.noreply.github.com>
Co-authored-by: Binbin Li <libinbin@microsoft.com>
Co-authored-by: Junjie Gao <junjiegao@microsoft.com>
Co-authored-by: Pritesh Bandi <priteshbandi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants