Lazily create certificates #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| // This will be flagged by the static code analyzer as 'Use of a weak cryptographic key' but its intentional | ||
| // and is used only for testing. | ||
| k, _ := rsa.GenerateKey(rand.Reader, 1024) |
Check failure
Code scanning / CodeQL
Use of a weak cryptographic key
Codecov Report
@@ Coverage Diff @@
## main #91 +/- ##
=======================================
Coverage 78.76% 78.76%
=======================================
Files 28 28
Lines 2067 2067
=======================================
Hits 1628 1628
Misses 336 336
Partials 103 103 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shizhMSFT
reviewed
Nov 4, 2022
rgnote
approved these changes
Nov 4, 2022
Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pritesh Bandi pritesb@amazon.com
Issue: notaryproject/notation#429
Time after fix: