update: validate Tag1 Datetime CBOR object #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## main #98 +/- ##
==========================================
+ Coverage 78.56% 78.86% +0.30%
==========================================
Files 28 28
Lines 2109 2139 +30
==========================================
+ Hits 1657 1687 +30
Misses 344 344
Partials 108 108
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
priteshbandi
previously approved these changes
Dec 2, 2022
There was a problem hiding this comment.
Would rely on review from @shizhMSFT for cose related unmarshalling code.
priteshbandi
dismissed
their stale review
mistakenly approved PR, there is feedback that needs to be addressed
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
shizhMSFT
reviewed
Dec 5, 2022
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
shizhMSFT
reviewed
Dec 5, 2022
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
shizhMSFT
approved these changes
Dec 5, 2022
signature/cose/envelope.go
Outdated
| return time.Time{}, fmt.Errorf("header %q time value does not have a tag", label) | ||
| } | ||
| if rawTag.Number != 1 { | ||
| return time.Time{}, errors.New("only Tag1 Datetime CBOR object is supported") |
There was a problem hiding this comment.
Suggested change
| return time.Time{}, errors.New("only Tag1 Datetime CBOR object is supported") | |
| return time.Time{}, errors.New("only Tag `1` Datetime CBOR object is supported") |
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR's purpose is to fix #97. Based on our spec, we will only support Tag1 Datetime in notary v2 COSE.
This PR adds validation of signing time and expiry (if exists) to make sure they are Tag1 Datetime CBOR objects. Objects other than Tag1 including Tag0 Datetime CBOR would trigger an error.
Signed-off-by: Patrick Zheng patrickzheng@microsoft.com