Create config with user only permission #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #269 +/- ##
==========================================
+ Coverage 73.23% 73.24% +0.01%
==========================================
Files 23 23
Lines 1984 1985 +1
==========================================
+ Hits 1453 1454 +1
Misses 429 429
Partials 102 102
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
JeyJeyGao
reviewed
Feb 7, 2023
shizhMSFT
reviewed
Feb 7, 2023
Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
priteshbandi
commented
Feb 8, 2023
Comment on lines
-151
to
153
| if *s.Default == name { | ||
| if s.Default !=nil && *s.Default == name { | ||
| s.Default = nil | ||
| } |
There was a problem hiding this comment.
This is actually a bug(unable to delete key if defualt key is not present) fix which I found while working on this PR
byronchien
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create config with user only permission
Signed-off-by: Pritesh Bandi pritesb@amazon.com