Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: running some chores for notation-go #311

Merged
merged 9 commits into from
May 19, 2023

Conversation

Two-Hearts
Copy link
Contributor

In this PR:

  1. According to issue Update references from Notary v2 to Notation #287, updated Notary v2 to Notation.
  2. Updated error messages of trust policy to improve user experience. Related issue: Improve the error for missing trust policy notation#621

Resolves #287

Signed-off-by: patrick <zongjunzheng@hotmail.com>
Signed-off-by: patrick <zongjunzheng@hotmail.com>
Signed-off-by: patrick <zongjunzheng@hotmail.com>
Signed-off-by: patrick <zongjunzheng@hotmail.com>
Signed-off-by: patrick <zongjunzheng@hotmail.com>
Signed-off-by: patrick <zongjunzheng@hotmail.com>
Signed-off-by: patrick <zongjunzheng@hotmail.com>
Signed-off-by: patrick <zongjunzheng@hotmail.com>
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2023

Codecov Report

Merging #311 (c508019) into main (1b9b7f2) will not change coverage.
The diff coverage is 66.66%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #311   +/-   ##
=======================================
  Coverage   74.39%   74.39%           
=======================================
  Files          23       23           
  Lines        2175     2175           
=======================================
  Hits         1618     1618           
  Misses        439      439           
  Partials      118      118           
Impacted Files Coverage Δ
plugin/proto/verify.go 0.00% <ø> (ø)
verifier/trustpolicy/trustpolicy.go 92.24% <66.66%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

README.md Outdated Show resolved Hide resolved
verifier/verifier_test.go Outdated Show resolved Hide resolved
internal/pkix/pkix.go Outdated Show resolved Hide resolved
plugin/proto/verify.go Outdated Show resolved Hide resolved
Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Two-Hearts. I left a few comments

Signed-off-by: patrick <zongjunzheng@hotmail.com>
@Two-Hearts Two-Hearts requested a review from yizha1 May 19, 2023 08:15
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update references from Notary v2 to Notation
5 participants