-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: running some chores for notation-go #311
Conversation
Signed-off-by: patrick <zongjunzheng@hotmail.com>
Signed-off-by: patrick <zongjunzheng@hotmail.com>
Signed-off-by: patrick <zongjunzheng@hotmail.com>
Signed-off-by: patrick <zongjunzheng@hotmail.com>
Signed-off-by: patrick <zongjunzheng@hotmail.com>
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #311 +/- ##
=======================================
Coverage 74.39% 74.39%
=======================================
Files 23 23
Lines 2175 2175
=======================================
Hits 1618 1618
Misses 439 439
Partials 118 118
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Two-Hearts. I left a few comments
Signed-off-by: patrick <zongjunzheng@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In this PR:
Notary v2
toNotation
.Resolves #287