-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
errors: add error for wild card scope validation #340
Conversation
Signed-off-by: Sajay Antony <sajaya@microsoft.com>
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #340 +/- ##
==========================================
+ Coverage 74.80% 74.88% +0.07%
==========================================
Files 23 23
Lines 2203 2210 +7
==========================================
+ Hits 1648 1655 +7
Misses 437 437
Partials 118 118
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
❯ cat trustpolicy.json --plain
{
"version": "1.0",
"trustPolicies": [
{
"name": "notation-demos-images",
"registryScopes": [ "localhost:5000/hello/*" ],
"signatureVerification": {
"level" : "strict"
},
"trustStores": [ "ca:notation-demos.io" ],
"trustedIdentities": [
"*"
]
}
]
}
❯ ./bin/notation policy import ./trustpolicy.json
Existing trust policy configuration found, do you want to overwrite it? [y/N] y
Error: failed to validate trust policy: registry scope "localhost:5000/hello/*" with wild card(s) is not valid, make sure it is a fully qualified repository without the scheme, protocol or tag. For example domain.com/my/repository or a local scope like local/myOCILayout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- upgrade `notation-go` from `v1.0.0-rc.6` to `v1.0.0` - upgrade dependencies for E2E tests - update E2E test case to reflect notaryproject/notation-go#340 --------- Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
No description provided.