revert: "feat: add support for signing blob (#379)" #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.1 #411 +/- ##
==============================================
Coverage ? 80.19%
==============================================
Files ? 31
Lines ? 2101
Branches ? 0
==============================================
Hits ? 1685
Misses ? 288
Partials ? 128 ☔ View full report in Codecov by Sentry. |
This reverts commit ec42378. Signed-off-by: Junjie Gao junjiegao@microsoft.com Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
JeyJeyGao
requested review from
gokarnm,
NiazFK,
priteshbandi,
rgnote,
shizhMSFT,
toddysm,
Two-Hearts,
vaninrao10 and
yizha1
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert:
TestSignOptsMissingSignatureMediaTypeandTestSignOptsUnknownMediaType, introduced in test: improve test coverage to 80% #405Test:
logpackage to pass 80% coverage targetThis reverts commit ec42378.
Resolves part of #412
Signed-off-by: Junjie Gao junjiegao@microsoft.com