Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump: bump up for v1.2.0 release #442

Merged
merged 5 commits into from
Aug 28, 2024
Merged

bump: bump up for v1.2.0 release #442

merged 5 commits into from
Aug 28, 2024

Conversation

Two-Hearts
Copy link
Contributor

No description provided.

dependabot bot and others added 4 commits August 27, 2024 13:49
@dependabot @Two-Hearts
build(deps): bump golang.org/x/mod from 0.19.0 to 0.20.0 (notaryproje…
bd776fd 
…ct#433)

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@dependabot @Two-Hearts
build(deps): bump golang.org/x/crypto from 0.25.0 to 0.26.0 (notarypr…
9a97fb7 
…oject#434)

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
bump: upgrade golang to v1.22 (notaryproject#440)
3d9eec4 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
bump up
1ab0c46 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@codecov Codecov
Copy link

codecov bot commented Aug 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.21%. Comparing base (a83c5be) to head (99c0c44).
Report is 1 commits behind head on release-1.2.

Additional details and impacted files 
@@             Coverage Diff              @@
##           release-1.2     #442   +/-   ##
============================================
  Coverage        81.21%   81.21%           
============================================
  Files               32       32           
  Lines             2279     2279           
============================================
  Hits              1851     1851           
  Misses             299      299           
  Partials           129      129

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeyJeyGao
Copy link
Contributor

Will we include #434 and #433 in this PR? or They will be another PR.

@Two-Hearts
Copy link
Contributor Author

Will we include #434 and #433 in this PR? or They will be another PR.

They are cherry picked and included in this PR.

JeyJeyGao
JeyJeyGao previously approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT reviewed Aug 27, 2024
View reviewed changes
signer/signer.go Outdated Show resolved Hide resolved
@Two-Hearts
update
99c0c44 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts Two-Hearts changed the title bump: release v1.2.0 bump: bump up for v1.2.0 release Aug 27, 2024
JeyJeyGao
JeyJeyGao approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT mentioned this pull request Aug 27, 2024
Merged
priteshbandi
priteshbandi approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts merged commit 7260694 into notaryproject:release-1.2 Aug 28, 2024
9 checks passed
@Two-Hearts Two-Hearts deleted the release-1.2 branch August 28, 2024 00:54
@Two-Hearts Two-Hearts mentioned this pull request Aug 28, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeyJeyGao JeyJeyGao JeyJeyGao approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@priteshbandi priteshbandi priteshbandi approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

@yizha1 yizha1 Awaiting requested review from yizha1 yizha1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Two-Hearts @JeyJeyGao @priteshbandi @shizhMSFT