feat: crl cache #462
Open
feat: crl cache #462
+495
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two-Hearts
requested review from
gokarnm,
JeyJeyGao,
NiazFK,
priteshbandi,
rgnote,
shizhMSFT,
toddysm,
vaninrao10 and
yizha1
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #462 +/- ##
==========================================
+ Coverage 81.01% 81.31% +0.29%
==========================================
Files 33 34 +1
Lines 2492 2553 +61
==========================================
+ Hits 2019 2076 +57
- Misses 331 333 +2
- Partials 142 144 +2 ☔ View full report in Codecov by Sentry. |
shizhMSFT
requested changes
Sep 20, 2024
Comment on lines
+62
to
+65
| // CacheFS is the cache SysFS | ||
| func CacheFS() SysFS { | ||
| return NewSysFS(userCacheDirPath()) | ||
| } |
There was a problem hiding this comment.
It seems that it is not used anywhere.
There was a problem hiding this comment.
This is intended to be used by callers of notation-go. For example, Notation CLI.
When caller wants to use crl.NewFileCache(root string), they will need to pass dir.CacheFS().SysPath() as root.
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an implementation of CRL cache along with {NOTATION_CACHE} directory for callers to initialize the cache.