Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: crl cache #462

Merged
merged 30 commits into from
Sep 26, 2024
Merged

feat: crl cache #462

merged 30 commits into from
Sep 26, 2024

Conversation

Two-Hearts
Copy link
Contributor

This PR adds an implementation of CRL cache along with {NOTATION_CACHE} directory for callers to initialize the cache.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 90.69767% with 8 lines in your changes missing coverage. Please review.

Project coverage is 81.34%. Comparing base (9faa6e2) to head (8df277a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/file/file.go 53.84% 3 Missing and 3 partials ⚠️
verifier/crl/crl.go 96.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #462      +/-   ##
==========================================
+ Coverage   81.01%   81.34%   +0.32%     
==========================================
  Files          33       34       +1     
  Lines        2492     2578      +86     
==========================================
+ Hits         2019     2097      +78     
- Misses        331      335       +4     
- Partials      142      146       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dir/fs.go Outdated Show resolved Hide resolved
verifier/verifier.go Outdated Show resolved Hide resolved
verifier/verifier.go Outdated Show resolved Hide resolved
verifier/crl/crl.go Outdated Show resolved Hide resolved
verifier/crl/crl.go Outdated Show resolved Hide resolved
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
dir/fs.go Outdated Show resolved Hide resolved
verifier/crl/crl.go Outdated Show resolved Hide resolved
verifier/crl/crl.go Outdated Show resolved Hide resolved
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
dir/fs.go Outdated Show resolved Hide resolved
dir/path.go Outdated Show resolved Hide resolved
verifier/crl/crl.go Outdated Show resolved Hide resolved
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
dir/path.go Show resolved Hide resolved
verifier/crl/crl.go Show resolved Hide resolved
verifier/crl/crl.go Outdated Show resolved Hide resolved
verifier/crl/crl.go Show resolved Hide resolved
verifier/crl/crl.go Show resolved Hide resolved
verifier/crl/crl.go Show resolved Hide resolved
verifier/crl/crl.go Outdated Show resolved Hide resolved
verifier/crl/crl.go Show resolved Hide resolved
verifier/crl/crl.go Outdated Show resolved Hide resolved
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
verifier/crl/crl.go Show resolved Hide resolved
verifier/crl/crl.go Outdated Show resolved Hide resolved
verifier/crl/crl.go Show resolved Hide resolved
verifier/crl/crl.go Show resolved Hide resolved
verifier/crl/crl.go Show resolved Hide resolved
verifier/crl/crl.go Show resolved Hide resolved
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
verifier/crl/crl.go Show resolved Hide resolved
internal/file/file.go Show resolved Hide resolved
verifier/crl/crl_test.go Show resolved Hide resolved
internal/file/file.go Outdated Show resolved Hide resolved
verifier/crl/crl.go Show resolved Hide resolved
internal/file/file.go Outdated Show resolved Hide resolved
verifier/crl/crl.go Outdated Show resolved Hide resolved
verifier/crl/crl.go Outdated Show resolved Hide resolved
verifier/crl/crl.go Show resolved Hide resolved
verifier/crl/crl.go Outdated Show resolved Hide resolved
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts merged commit 84c2ec0 into notaryproject:main Sep 26, 2024
9 checks passed
@Two-Hearts Two-Hearts deleted the crl branch September 26, 2024 02:00
@Two-Hearts Two-Hearts mentioned this pull request Sep 27, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants