fix: resolve comment

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
notaryproject · Dec 27, 2022 · db9d3b4 · db9d3b4
1 parent 728d489
commit db9d3b4
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -35,7 +35,6 @@ jobs:
       - name: Run unit tests
         run: make test
       - name: Run e2e tests
-        run:  | 
-          make e2e
+        run:  make e2e
       - name: Upload coverage to codecov.io
         uses: codecov/codecov-action@v3
diff --git a/test/e2e/internal/notation/key.go b/test/e2e/internal/notation/key.go
@@ -40,7 +40,9 @@ func AddTestKeyPairs(dir string) error {
 
 	// create localkeys directory
 	localKeysDir := filepath.Join(dir, localkeysDirName)
-	os.MkdirAll(localKeysDir, os.ModePerm)
+	if err := os.MkdirAll(localKeysDir, os.ModePerm); err != nil {
+		return err
+	}
 	if err := copyFile(NotationE2EKeyPath, filepath.Join(localKeysDir, "e2e.key")); err != nil {
 		return err
 	}

diff --git a/test/e2e/internal/notation/registry.go b/test/e2e/internal/notation/registry.go
@@ -28,7 +28,7 @@ type Registry struct {
 	Password string
 }
 
-var TestRegistry = Registry{}
+var TestRegistry Registry
 
 type Artifact struct {
 	*Registry