Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests and CodeQL scanning in GitHub CI/CD #197

Closed
FeynmanZhou opened this issue Jun 10, 2022 · 5 comments
Closed

Add unit tests and CodeQL scanning in GitHub CI/CD #197

FeynmanZhou opened this issue Jun 10, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@FeynmanZhou
Copy link
Member

FeynmanZhou commented Jun 10, 2022

In order to ensure the high quality of project delivery, I propose to improve the automated testing process for Notary v2. Currently, we need to add some basic e2e tests, unit tests, and integration tests for notation, notation-go, and notation-core-go.

As Notation CLI is used for end-users and it has multiple packages for different platforms (Linux amd64 & arm64 and Windows), it is also recommended to consider the basic usability test cases (e.g. install, build, push, sign, verify) in the automated testing script.

@FeynmanZhou FeynmanZhou added the enhancement New feature or request label Jun 10, 2022
@dtzar dtzar added this to the rc.1 milestone Jun 10, 2022
@dtzar
Copy link
Contributor

dtzar commented Jun 10, 2022

I would like to scope this item to just the E2E testing for notation cli - this will inherently test at least parts of the API "pseudo integration".
notation-go already has unit tests.
notation-core-go I added notaryproject/notation-core-go#6
Full integration tests should be broken out in a separate work item, but it isn't priority for RC1.

@FeynmanZhou
Copy link
Member Author

I would like to scope this item to just the E2E testing for notation cli - this will inherently test at least parts of the API "pseudo integration". notation-go already has unit tests. notation-core-go I added notaryproject/notation-core-go#6 Full integration tests should be broken out in a separate work item, but it isn't priority for RC1.

Agree, we could iterate it in the next release.

@dtzar dtzar changed the title Improve the automated testing process E2E tests for key CLI flows with CI Jun 10, 2022
@Wwwsylvia
Copy link
Contributor

Wwwsylvia commented Jun 15, 2022

FYI, I'm adding code scan, unit tests and coverage report to notation, notation-go, and notation-core-go.

Here are the PRs I currently have:

@FeynmanZhou
Copy link
Member Author

FeynmanZhou commented Jun 15, 2022

@Wwwsylvia Thanks for your updates. I see Shiwei is reviewing these PRs.

@dtzar dtzar moved this to In Progress in Notary Project Planning Board Jun 29, 2022
@FeynmanZhou FeynmanZhou changed the title E2E tests for key CLI flows with CI Add unit tests and CodeQL scanning in GitHub CI/CD Jun 29, 2022
@dtzar
Copy link
Contributor

dtzar commented Jul 21, 2022

All of these are merged, so closing out this issue.

@dtzar dtzar closed this as completed Jul 21, 2022
Repository owner moved this from In Progress to Done in Notary Project Planning Board Jul 21, 2022
@dtzar dtzar modified the milestones: RC-1, alpha-3 Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

3 participants