Setup Github workflow #8
Conversation
.github/workflows/build.yml
Outdated
| - name: Run unit tests | ||
| run: make test |
There was a problem hiding this comment.
I'm curious why the steps across notation, notation-go, and notation-core-go are slightly different, can they all be the same set of steps. Can they be reused workflows defined in a single place?
There was a problem hiding this comment.
Defined a reusable workflow.
.github/workflows/build.yml
Outdated
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
We should update notation build.yml to use the same.
There was a problem hiding this comment.
Can we also build/test on Windows and Mac?
There was a problem hiding this comment.
Make sense. But we may want to do this in a seperate PR, as currently we use make test to generate coverage report, which will not work on Windows.
There was a problem hiding this comment.
@gokarnm Updated notation workflow. See notaryproject/notation#212.
Signed-off-by: Lixia (Sylvia) Lei <lixia_lei@outlook.com>
Signed-off-by: Lixia (Sylvia) Lei <lixia_lei@outlook.com>
Signed-off-by: Lixia (Sylvia) Lei lixia_lei@outlook.com