Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: e2e framework #493

Merged
merged 24 commits into from
Jan 11, 2023
Merged

test: e2e framework #493

merged 24 commits into from
Jan 11, 2023

Conversation

JeyJeyGao
Copy link
Contributor

@JeyJeyGao JeyJeyGao commented Dec 22, 2022 •
edited
Loading

Please follow this order to review: this PR -> #494

  • Added Notaton E2E integration test framework in ./test/e2e directory
  • Added Github Action E2E test
  • Added multi-registry support: zot, dockerhub

Signed-off-by: Junjie Gao junjiegao@microsoft.com
Signed-off-by: zaihaoyin zaihaoyin@microsoft.com

zaihaoyin and others added 8 commits December 22, 2022 13:08
@JeyJeyGao
feat:support notation cli end-to-end test framework
56819b7 
Signed-off-by: zaihaoyin <zaihaoyin@microsoft.com>
@JeyJeyGao
feat: notation e2e test framework
7a86c1c 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: optimize and add comments
4706afc 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: optimize exec
4da3fef 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update CI
740fe14 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: update CI
72b5ec0 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: remove github logic
8e718e3 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: optimize code
58aa178 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2022 •
edited
Loading

Codecov Report

Merging #493 (bc50cd7) into main (f83a48b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #493   +/-   ##
=======================================
  Coverage   29.57%   29.57%           
=======================================
  Files          26       26           
  Lines        1515     1515           
=======================================
  Hits          448      448           
  Misses       1050     1050           
  Partials       17       17

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JeyJeyGao JeyJeyGao force-pushed the feat/e2e_framework branch 2 times, most recently from 1c873e1 to 77f6b7a Compare December 22, 2022 07:37
@JeyJeyGao
fix: update readme
9166098 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: removed docker file
05c1c22 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao JeyJeyGao changed the title feat: e2e framework test: e2e framework Dec 22, 2022
shizhMSFT
shizhMSFT reviewed Dec 22, 2022
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
test/e2e/Readme.md Outdated Show resolved Hide resolved
test/e2e/internal/notation/registry.go Outdated Show resolved Hide resolved
test/e2e/internal/notation/registry.go Outdated Show resolved Hide resolved
test/e2e/internal/notation/registry.go Outdated Show resolved Hide resolved
test/e2e/internal/notation/registry.go Outdated Show resolved Hide resolved
test/e2e/internal/notation/trustpolicy.go Outdated Show resolved Hide resolved
@JeyJeyGao
fix: resolve comments
09472df 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: use GinkgoT().TempDir()
6f8a714 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: resolve comments
f0f0b4d 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: optimize matcher
b8cc09c 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
test: add quickstart e2e test
00a6f9d 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
fix: optimize pipeline
77c22fd 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
remove: quickstart e2e test
8866f09 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao JeyJeyGao mentioned this pull request Dec 26, 2022
Merged
@JeyJeyGao
fix: remove cache.db
09da685 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
remove: quickstart trustpolicy
728d489 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
shizhMSFT
shizhMSFT reviewed Dec 27, 2022
View reviewed changes
.github/workflows/build.yml Outdated Show resolved Hide resolved
test/e2e/internal/notation/key.go Outdated Show resolved Hide resolved
test/e2e/internal/notation/registry.go Show resolved Hide resolved
chloeyin
chloeyin reviewed Jan 4, 2023
View reviewed changes
test/e2e/run.sh Outdated Show resolved Hide resolved
@JeyJeyGao JeyJeyGao force-pushed the feat/e2e_framework branch 6 times, most recently from 5b295b4 to 38872f6 Compare January 4, 2023 14:56
@JeyJeyGao
test: update to use oras-go copy
24a0885 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
patrickzheng200
patrickzheng200 reviewed Jan 5, 2023
View reviewed changes
test/e2e/internal/notation/file.go Show resolved Hide resolved
test/e2e/internal/notation/file.go Outdated Show resolved Hide resolved
test/e2e/internal/notation/file.go Outdated Show resolved Hide resolved
test/e2e/internal/notation/key.go Outdated Show resolved Hide resolved
test/e2e/internal/notation/registry.go Outdated Show resolved Hide resolved
test/e2e/internal/notation/registry.go Show resolved Hide resolved
test/e2e/internal/utils/host.go Outdated Show resolved Hide resolved
test/e2e/suite/command/sign.go Show resolved Hide resolved
@JeyJeyGao
test: added dockerhub support
da03daf 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao
test: resolve comments
cb62533 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
patrickzheng200
patrickzheng200 approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@patrickzheng200 patrickzheng200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT reviewed Jan 9, 2023
View reviewed changes
test/e2e/internal/notation/file.go Outdated Show resolved Hide resolved
test/e2e/internal/notation/file.go Show resolved Hide resolved
test/e2e/internal/notation/registry.go Outdated Show resolved Hide resolved
@JeyJeyGao
fix: resolve comemnts
bc50cd7 
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
priteshbandi
priteshbandi approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some feedback

test/e2e/suite/command/sign.go Show resolved Hide resolved
test/e2e/run.sh Show resolved Hide resolved
shizhMSFT
shizhMSFT approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 573b17f into notaryproject:main Jan 11, 2023
priteshbandi pushed a commit to priteshbandi/notation that referenced this pull request Feb 1, 2023
@JeyJeyGao
test: e2e framework (notaryproject#493)
3b13295 
- Added Notaton E2E integration test framework in ./test/e2e directory
- Added Github Action E2E test
- Added multi-registry support: zot, dockerhub

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Co-authored-by: zaihaoyin <zaihaoyin@microsoft.com>
@rchincha rchincha mentioned this pull request Feb 13, 2023
Closed
@yizha1 yizha1 linked an issue Feb 17, 2023 that may be closed by this pull request
E2E Automation Testing for CLI commands notaryproject/roadmap#47
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchincha rchincha rchincha left review comments

@chloeyin chloeyin chloeyin left review comments

@qweeah qweeah qweeah left review comments

@patrickzheng200 patrickzheng200 patrickzheng200 approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@priteshbandi priteshbandi priteshbandi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

E2E Automation Testing for CLI commands
8 participants
@JeyJeyGao @codecov-commenter @qweeah @priteshbandi @chloeyin @shizhMSFT @rchincha @patrickzheng200