-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugin)!: pass payload digest when generate-signature
#185
Conversation
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
This PR is also for COSE support since the Signer of |
Moving certificateChain from |
As discussed in the community call, I will remove this part out to another PR #187 for discussions. |
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
generate-signature
We can close this PR if veraison/go-cose#101 is merged. |
Changes to
SIGNATURE_GENERATOR.RAW
capability:payloadDigest
instead ofpayload
is passed ingenerate-signature.request
.notation-core-go
.notation-go
still uses golang built-in hash implementation to do signature and certificate validation. For advanced scenarios, it should be considered compilingnotation
under FIPS-compliant golang or implementing a plugin withSIGNATURE_GENERATOR.ENVELOPE
capability.Signed-off-by: Shiwei Zhang shizh@microsoft.com