remove route (get from beatmapset instead)

notbakaneko · Dec 17, 2024 · 5ad134a · 5ad134a
1 parent f5552af
commit 5ad134a
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 42 deletions.
diff --git a/app/Http/Controllers/BeatmapTagsController.php b/app/Http/Controllers/BeatmapTagsController.php
@@ -23,15 +23,6 @@ public function __construct()
                 'destroy',
             ],
         ]);
-
-        $this->middleware('require-scopes:public', ['only' => 'index']);
-    }
-
-    public function index($beatmapId)
-    {
-        return [
-            'beatmap_tags' => Beatmap::findOrFail($beatmapId)->topTagsJson(),
-        ];
     }
 
     public function destroy($beatmapId, $tagId)

diff --git a/routes/web.php b/routes/web.php
@@ -430,7 +430,7 @@
                     });
                 });
 
-                Route::apiResource('tags', 'BeatmapTagsController', ['only' => ['index', 'store', 'destroy']]);
+                Route::apiResource('tags', 'BeatmapTagsController', ['only' => ['store', 'destroy']]);
             });
         });
 

diff --git a/tests/Controllers/BeatmapTagsControllerTest.php b/tests/Controllers/BeatmapTagsControllerTest.php
@@ -12,7 +12,6 @@
 use App\Models\Solo\Score;
 use App\Models\Tag;
 use App\Models\User;
-use Illuminate\Testing\Fluent\AssertableJson;
 use Tests\TestCase;
 
 class BeatmapTagsControllerTest extends TestCase
@@ -21,21 +20,6 @@ class BeatmapTagsControllerTest extends TestCase
     private Beatmap $beatmap;
     private BeatmapTag $beatmapTag;
 
-    public function testIndex(): void
-    {
-        $this->actAsScopedUser(User::factory()->create(), ['public']);
-
-        $this
-            ->get(route('api.beatmaps.tags.index', ['beatmap' => $this->beatmap->getKey()]))
-            ->assertSuccessful()
-            ->assertJson(fn (AssertableJson $json) =>
-                $json
-                    ->where('beatmap_tags.0.id', $this->tag->getKey())
-                    ->where('beatmap_tags.0.name', $this->tag->name)
-                    ->where('beatmap_tags.0.count', 1)
-                    ->etc());
-    }
-
     public function testStore(): void
     {
         $user = User::factory()

diff --git a/tests/api_routes.json b/tests/api_routes.json
@@ -173,22 +173,6 @@
         ],
         "scopes": []
     },
-    {
-        "uri": "api/v2/beatmaps/{beatmap}/tags",
-        "methods": [
-            "GET",
-            "HEAD"
-        ],
-        "controller": "App\\Http\\Controllers\\BeatmapTagsController@index",
-        "middlewares": [
-            "App\\Http\\Middleware\\ThrottleRequests:1200,1,api:",
-            "App\\Http\\Middleware\\RequireScopes",
-            "App\\Http\\Middleware\\RequireScopes:public"
-        ],
-        "scopes": [
-            "public"
-        ]
-    },
     {
         "uri": "api/v2/beatmaps/{beatmap}/tags",
         "methods": [
-Original file line number
+Diff line change
@@ Expand Up / @@ -430,7 +430,7 @@ @@
                         });
                     });
-                    Route::apiResource('tags', 'BeatmapTagsController', ['only' => ['index', 'store', 'destroy']]);
+                    Route::apiResource('tags', 'BeatmapTagsController', ['only' => ['store', 'destroy']]);
                 });
             });
@@ Expand Down @@