Issues with mediated workflows

[jillpe]

Summary

1. Appears to be resolved: Issue with workflows being used when admin set specified default workflow

Details

This may have been an error due to unmigrated collections/admin sets. I have not been able to duplicate this problem since.

I made a new admin set with no mediated workflow and created a work in that admin set and it still said it’s pending review. I didn’t get an error approving it, but it shouldn’t have that workflow

https://demo.hykucommons.org/concern/generic_works/b17e7783-f6b5-44ca-a976-4ace994f5579?locale=en

2. Issues with mediated deposit still occuring

I am not positive but appears we have several issues (there could be more that I haven’t yet found):

In some cases, new Valkyrie works with mediated deposit don’t appear on the Review Submissions list

In some cases, the counts appear but no items are listed on the first several pages. Earlier works begin on later pages and those have the problem detailed in the next point. This failure to appear on the list seems to be just the new valkyrie works, but in local testing the new works appeared on my list.

Additionally, the count of items on the list apparently includes child works from split PDFs. We should really omit the split child works from any approval process and the review list, and approve them automatically when the parent is approved. The screenshot below is from this page

ActiveFedora works with mediated deposit appear on the list but don’t have the workflow actions showing on the item

I have tracked this problem down to an issue with the sipity model and the active fedora model mapper. When it tries to find the entity, it ends up with an error, so the workflow actions widget doesn’t find any workflow actions and doesn’t display. I have a failing spec but am not sure yet what I can change/override to fix the issue.

D, [2025-02-20T00:04:03.016655 #318] DEBUG -- : Trying to make an Entity for #<Hyrax::ActiveFedoraDummyModel:0x00007f95ee6d0c78 @model=GenericWorkResource, @id="536777cc-59d0-4916-8e9e-767e6f9e9fe7">
D, [2025-02-20T00:04:03.016702 #318] DEBUG -- : Entity() got something else, testing #to_global_id
D, [2025-02-20T00:04:03.018058 #318] DEBUG -- : Trying to make an Entity for #<URI::GID gid://hyku/Hyrax::ValkyrieGlobalIdProxy/536777cc-59d0-4916-8e9e-767e6f9e9fe7>
D, [2025-02-20T00:04:03.018104 #318] DEBUG -- : Entity() got a GID, searching by proxy
D, [2025-02-20T00:04:03.020599 #318] DEBUG -- :   Sipity::Entity Load (0.9ms)  SELECT "sipity_entities".* FROM "sipity_entities" WHERE "sipity_entities"."proxy_for_global_id" = $1 LIMIT $2  [["proxy_for_global_id", "gid://hyku/Hyrax::ValkyrieGlobalIdProxy/536777cc-59d0-4916-8e9e-767e6f9e9fe7"], ["LIMIT", 1]]
D, [2025-02-20T00:04:03.020775 #318] DEBUG -- : Entity(): attempting conversion on 
/usr/local/bundle/bundler/gems/hyrax-3788d40be037/app/models/sipity.rb:177:in `handle_conversion': Unable to convert #<URI::GID gid://hyku/Hyrax::ValkyrieGlobalIdProxy/536777cc-59d0-4916-8e9e-767e6f9e9fe7> (Sipity::ConversionError)

Acceptance Criterias

• Creating works in non-mediated workflow admin sets completes and the status updates accordingly
• Creating works in mediated deposit workflow admin sets appear on list for subsequent review & approval
• Works requiring approval show the approval widget on their show page

[jillpe]

Nic Don: https://notch8.slack.com/archives/C088B7HJJ1E/p1739814184071979

I have two tenants reporting that their works are not accessible to approve for individuals with deposit approval roles. I have confirmed this with my superadmin, this is what I see when I navigate to the work page.

This is not occurring in my tenant or my test tenants (this is on production btw).
Two questions: 1) is there a data repair job that would touch this? 2) How do I structure the link to view the sidekiq to know when a job has been run?

[ndroark]

Additional behavior description from an admin user:

Apparently this is only happening for works I did not create. I have about 40 works created by others that I need to approve. I can get in and edit the work but when I save it I still get the message “The work is not currently available because it has not yet completed the approval process”.

I have tried transferring the work to my ownership but I still get the same message.

I created a new work this morning and was able to review and approve it just fine.

[laritakr]

I believe fixing hyrax should resolve most of the issues. samvera/hyrax#7028

[ndroark]

Located a work that is still experiencing this bug: https://huntington.hykucommons.org/concern/generic_works/2f6da5dd-9314-421f-b0dd-fda84fec9ee3?locale=en. There are some other works in this repository experiencing it, most pending works are not.

[ndroark]

According to the user, this happens if works are pending approval, and then edited. After the edits, they are moved into this locked state.

[laritakr]

I have a fix to prevent more problems from happening.

Unfortunately the data that is already wrong such as the huntington work linked above will need to be cleaned up separately. I made a new ticket for that issue.

#285