-
-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple changes #141
Merged
Merged
Multiple changes #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
~ The content is now automatically centred always ~ Changed margins between elements for niceness ~ Added a "username" field (does not do anything yet, for later revision)
~ Reformatted most project files to my preference
~ Changed default sans font to Noto Sans, for consistency across devices. If Noto Sans is not available (although it is now included with Notea), it will fall back to the previous sans set.
~ Exporting now keep the directory structure intact (available through /api/export) + /api/tree now accepts a `style` query parameter. `style=hierarchy` shows a hierarchical representation of the tree instead of the usual list style.
~ Importing now uses a directory structure, however the if a markdown file shares a name with a directory, the two are not merged.
~ This was a bug found whilst I was testing the new import logic.
~ IconButton now accepts "Refresh", which will produce Heroicons' Refresh icon.
+ Notea now accepts a CONFIG_FILE environment variable, which supports all the options that the previous environment configuration provided. The equivalent of each option can be found in config/compatibility.yml.
~ Added node_modules to the .dockerignore file. This will result in considerably faster build times.
change(docker): The Docker image provides a default CONFIG_FILE value, along with a volume for it change(docker): The Dockerfile is now based on the node:16-alpine image instead of lts-alpine, to ensure stability.
change(next): The configuration now provides a middleware webpack configuration function before passing it to withPWA's webpack function.
change(auth): libs/server/auth.ts is a utility for separating authentication verification from the other files slightly better (and also not just blatantly comparing the PASSWORD environment variable).
fix(config): There was a usage of getEnv("BASE_URL") left in libs/server/middlewares/note.ts.
fix(config): The loader did not consider the file configuration's `baseUrl` value for the base URL configuration. This has been rectified.
…ectly run-s: `run-s` allows for any package manager to be used.
js-yaml: js-yaml is the YAML parser used in the new configuration system. I forgot to install/commit it earlier.
version: The version has been bumped to 0.3.7-alpha. repository: The `repository` field has been changed to represent the fork's repository rather than the now-archived upstream.
footer: The footer now displays information from both the original and fork.
README: The "Use Logseq instead" header has been removed, and some grammar issues have been fixed. yarn.lock: The lockfile has been updated.
.dev: The `.dev` directory can be used for private files used for developers, for example temporary Minio data for testing.
arrow-parens: Arrow functions are now required to have parentheses around arguments (i.e. `(_) => {}` is good, but `_ => {}` is not)
prettierignore: Prettier will now ignore files that are not files for reformatting.
reformat: All files have been reformatted.
compatibility.yml: The compatibility example now includes documentation for baseUrl, and an example.
README: The README file has been changed in preparation for pulling changes from my fork to the upstream, now living under @notea-org.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelist (mainly for users):