fix: default image zoom not being triggerable #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The editor theme color was rewritten by me, but I have not developed the dark theme yet https://github.com/QingWei-Li/notea/blob/main/components/editor/theme.ts Fixed via 66cfd5d |
QingWei-Li
changed the title
Nice! Thanks for fixing it immediately 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can see another theme library (likely Mui) was disabling the default image zoom functionality? The same seems to be happening with code syntax highlighting (rich-markdown-editor should have dark mode syntax highlighting). Do you have any idea where these overrides are coming from?
Preview of fix
2021-08-29_13-44-25.mp4