Changed tokio crossbeam example from kqueue to fsevent #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xpr03
requested changes
Jun 26, 2024
| @@ -36,10 +36,9 @@ | |||
| //! You can disable crossbeam-channel, letting notify fallback to std channels via | |||
| //! | |||
| //! ```toml | |||
| //! notify = { version = "6.1.1", default-features = false, features = ["macos_kqueue"] } | |||
| //! // Alternatively macos_fsevent instead of macos_kqueue | |||
There was a problem hiding this comment.
please don't remove this, if you only watch a little amount of files, kqueue is totally valid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the example code for turning off crossbeam for tokio to use
macos_fseventinstead ofmacos_kqueueI'm suggesting this change based off the issue I'm seeing with too many open files with kqueue
My thinking is that this will help prevent folks running into the
kqueueby usingfseventinstead