Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename text property of blocks to rich_text #262

Conversation

KoditkarVedant
Copy link
Contributor

Description

Renamed the text property to rich_text. This affects the following block types: paragraph, heading_1, heading_2, heading_3, callout, quote, bulleted_list_item, numbered_list_item, to_do ,toggle, code ,template.

Fixes # (issue)
#242

Type of change

  • Breaking change (Feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Updated the integration tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@KoditkarVedant KoditkarVedant merged commit 5c2970d into notion-version-2022-02-22 Jul 10, 2022
@KoditkarVedant KoditkarVedant deleted the 242-rename-text-prop-to-rich_text-in-block branch July 10, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The text in blocks has been renamed to rich_text, to be consistent with the database property type..
1 participant