Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include arm64 arch for linux builds #34

Merged
merged 2 commits into from
Sep 22, 2021
Merged

Include arm64 arch for linux builds #34

merged 2 commits into from
Sep 22, 2021

Conversation

jamezrin
Copy link
Member

No description provided.

@jamezrin
Copy link
Member Author

jamezrin commented Sep 21, 2021

@dragonwocky what do you think?
Increases a bit the build time but might be worth it, already tested it locally, and it works.
Should we include it for Windows too? I don't have any arm64 device that runs Windows...

Copy link
Member

@dragonwocky dragonwocky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Build time isn't fast anyway, so a little extra time isn't that big of a deal. Support for more devices/platforms is always good.
I don't have an arm64 device running Windows either, we could try find someone on Discord to test that?

@jamezrin
Copy link
Member Author

I have looked at the state of Windows for Arm64, and it doesn't seem too exciting yet, we can easily enable it in the future if we deem it necessary. Merging this and releasing rev 5

@jamezrin jamezrin merged commit aefeeea into main Sep 22, 2021
@jamezrin jamezrin deleted the arm64-target-linux branch September 27, 2021 17:35
@viveksh1
Copy link

@jamezrin @dragonwocky
Any update on providing builds for Windows arm64?

Now that the “Copilot+PC”(Windows ARM) laptops are getting more popular (Microsoft Surface Laptop, Dell XPS 13, HP OmniBook X 14, and more), and that Notion provides builds for arm64 Windows, are there any plans to provide binaries for Notion Repackaged on Windows arm64?

Please try to add support and builds soon so that Notion Repackaged can be much more usable on Windows on ARM.

Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants