Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Prisma v4 #37

Merged
merged 2 commits into from
Jul 18, 2022
Merged

Update to Prisma v4 #37

merged 2 commits into from
Jul 18, 2022

Conversation

PabloSzx
Copy link
Contributor

@PabloSzx PabloSzx commented Jul 4, 2022

Closes #34

@PabloSzx
Copy link
Contributor Author

PabloSzx commented Jul 4, 2022

cc @marcjulian

@PabloSzx
Copy link
Contributor Author

PabloSzx commented Jul 4, 2022

image
there seems to be another issue that isn't caught by the tests, because when generating in a reasonably sized project it's frozen, when removing the dbml generator provider it does generate correctly

marcjulian
marcjulian approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@marcjulian marcjulian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marcjulian marcjulian merged commit b3615ce into notiz-dev:main Jul 18, 2022
@marcjulian marcjulian mentioned this pull request Jul 18, 2022
Open
@marcjulian
Copy link
Member

@PabloSzx thanks again for the PR!

I released a dev version to test it out

npm i -D prisma-dbml-generator@0.10.0-dev.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcjulian marcjulian marcjulian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upcoming rename of @prisma/sdk to @prisma/internals with Prisma 4
2 participants
@PabloSzx @marcjulian