Skip to content

Commit

Permalink
Merge bitcoindevkit#57: if no wallet name was provided, use one deriv…
Browse files Browse the repository at this point in the history
…ed from the descriptor

9b278bd Bump bdk and bdk-reserves version to 0.16 (Richard Ulrich)
e52e819 if no wallet name was provided, use one derived from the descriptor (Richard Ulrich)

Pull request description:

  ### Description

  if no wallet name was provided, use one derived from the descriptor

  ### Notes to the reviewers

  Is there a better place to use wallet_name_from_descriptor so that the generated name shows up in the unit tests instead of the placeholder?

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk-cli/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

Top commit has no ACKs.

Tree-SHA512: 3ea0ce74c6447174329dfed7eb3721faa5596cbaf3b746b2134f0b02b512533e69e54e28c3d8692abb885f86345c47367999bcea307977c67106dbc33fb466a9
  • Loading branch information
notmandatory committed Jan 25, 2022
2 parents 40a0138 + 9b278bd commit 49c9a9f
Show file tree
Hide file tree
Showing 5 changed files with 94 additions and 364 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Replace `wallet bump_fee` command `--send_all` with new `--shrink` option
- Add 'reserve' feature to enable proof of reserve
- If no wallet name is provided, derive one from the descriptor instead of using "main"

## [0.3.0]

Expand Down
230 changes: 7 additions & 223 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 49c9a9f

Please sign in to comment.