Skip to content

Commit

Permalink
use span instead of div for since version
Browse files Browse the repository at this point in the history
euclio committed May 3, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1 parent ef9a876 commit 8fc6e42
Showing 3 changed files with 4 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/librustdoc/html/render.rs
Original file line number Diff line number Diff line change
@@ -3410,7 +3410,7 @@ fn render_stability_since_raw<'a, T: fmt::Write>(
) -> fmt::Result {
if let Some(v) = ver {
if containing_ver != ver && v.len() > 0 {
write!(w, "<div class='since' title='Stable since Rust version {0}'>{0}</div>", v)?
write!(w, "<span class='since' title='Stable since Rust version {0}'>{0}</span>", v)?
}
}
Ok(())
2 changes: 1 addition & 1 deletion src/librustdoc/html/static/rustdoc.css
Original file line number Diff line number Diff line change
@@ -914,7 +914,7 @@ h3 > .collapse-toggle, h4 > .collapse-toggle {
height: 12px;
}

span.since {
.out-of-band > span.since {
position: initial;
font-size: 20px;
margin-right: 5px;
5 changes: 2 additions & 3 deletions src/test/rustdoc/assoc-consts-version.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// ignore-tidy-linelength

#![crate_name = "foo"]

#![feature(staged_api)]
@@ -10,7 +8,8 @@
pub struct SomeStruct;

impl SomeStruct {
// @has 'foo/struct.SomeStruct.html' '//*[@id="associatedconstant.SOME_CONST"]//div[@class="since"]' '1.1.2'
// @has 'foo/struct.SomeStruct.html' \
// '//*[@id="associatedconstant.SOME_CONST"]//span[@class="since"]' '1.1.2'
#[stable(since="1.1.2", feature="rust2")]
pub const SOME_CONST: usize = 0;
}

0 comments on commit 8fc6e42

Please sign in to comment.