Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding joke feature. #67

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adding joke feature. #67

wants to merge 2 commits into from

Conversation

bundz
Copy link

@bundz bundz commented Apr 26, 2017

I added a joke feature. The parrot spokes a joke every 20 minutes instead of last tweet. Jokes come from tambalAPI. I have changed the config.js to get an env variable TTC_JOKE. If TTC_JOKE is true, the parrot will tell you a joke every 20 minutes. Here's an example:
screen shot 2017-04-26 at 08 53 32

@Garbee
Copy link
Contributor

Garbee commented Apr 26, 2017

Personally I like the idea but this kinda collides with #52 as well since that uses the bird area as well.

Perhaps we should look into a way to handle multiple things running using the space and how to handle that.

@bundz
Copy link
Author

bundz commented Apr 26, 2017

I think the parrot should say something fun or something to make you happy. I was thinking about create a box to pomodoro timer. Anyway nice project guys!

@notwaldorf
Copy link
Owner

notwaldorf commented Apr 26, 2017

Aww thanks for liking this! I like the joke feature! I think rather than having a TTC_JOKE, there should be a TTC_PARROT = twitteraccount | joke option. It would be tinycarebot by default, but when updated to joke, would tell a joke. @bundz WDYT?

@notwaldorf notwaldorf added the ⏳ pending-response What are you waiting for? Christmas? label Apr 26, 2017
@notwaldorf notwaldorf mentioned this pull request Apr 26, 2017
@bundz
Copy link
Author

bundz commented Apr 26, 2017

Agreed! 👍 😆

@notwaldorf
Copy link
Owner

Oh, I actually have a better idea. What if we use TTC_BOTS instead, and replace the first twitter account with ttc_joke_bot. It's a hardcoded string, and we can rework the logic to skip it for the tweet response, and then the parrot can just say it that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⏳ pending-response What are you waiting for? Christmas?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants