feat: Configuration for correlation plugin #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chsukivra
commented
Dec 22, 2023
chsukivra
commented
- request_correlation_header, if set take this request's header value and use as correlation id
- logger_metadata_key, override the entry in logger metadata (default: <<"correlation-id">>)
- dictionary_key, additional process dictionary entry storing corr id (default: correlation_id)
- request_correlation_header, if set take this request's header value and use as correlation id - logger_metadata_key, override the entry in logger metadata (default: <<"correlation-id">>) - dictionary_key, additional process dictionary entry storing corr id (default: correlation_id)
|
This is just a draft of something that would make the built in correlation plugin a bit more useful for us, and maybe for other users of nova. |
burbas
approved these changes
Dec 22, 2023
| Req1 = cowboy_req:set_resp_header(<<"X-Correlation-ID">>, UUID, Req), | ||
| ok = update_logger_metadata(CorrId, Opts), | ||
| %% Redundant entry, allow controllers to erlang:get(correlation_id) | ||
| ok = put_process_dictionary(CorrId, Opts), |
There was a problem hiding this comment.
It's probably a better idea to set a key in the Req object instead for keeping this in the process-dictionary.
There was a problem hiding this comment.
changed so that it is set as the correlation_id field in the request object.
Taure
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.