-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transaction builder draft #1258
base: dev
Are you sure you want to change the base?
Conversation
Current coverage reportSummary
Tests which was executed
Coverage by files (34%)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First part of questions
src/renderer/entities/transactionBuilder/lib/compound-wallet.ts
Outdated
Show resolved
Hide resolved
src/renderer/entities/transactionBuilder/lib/compound-wallet.ts
Outdated
Show resolved
Hide resolved
src/renderer/entities/transactionBuilder/lib/compound-wallet.ts
Outdated
Show resolved
Hide resolved
src/renderer/entities/transactionBuilder/lib/compound-wallet.ts
Outdated
Show resolved
Hide resolved
src/renderer/entities/transactionBuilder/lib/compound-wallet.ts
Outdated
Show resolved
Hide resolved
src/renderer/entities/transactionBuilder/lib/compound-wallet.ts
Outdated
Show resolved
Hide resolved
src/renderer/entities/transactionBuilder/lib/compound-wallet.ts
Outdated
Show resolved
Hide resolved
|
||
transactionBuilder.visitAll({ | ||
visitMultisig(visit: MultisigVisit) { | ||
// TODO check who pays deposit in case multisig is wrapped in some other structure, like proxy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If that helps, the submitter always pays the deposit for the multisig transaction state. Now depending on the action performed, there may be other deposit required. for instance:
- A multisig is creating a proxy. The submitter needs ~20 DOTs for the multisig tx, but the Multisig that will then create the proxy will also need 20 DOTs for the proxy creation deposit
- A Multisig with pure proxy sets an identity. The submitter needs ~20 DOTs for the multisig tx, but the Multisig that will then set an will also need 20 DOTs for the identity deposit
TL;DR, the depositor/submitter needs the multisig tx deposit, but the transaction may fail when being submitted by the last signatory, because of some other deposit.
@valentunn don't you mind if I close this PR? |
No description provided.