Feature/updated receive screen #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
feature/change-icons-style
to
base/portfolio-view
October 30, 2024 09:11
ERussel
reviewed
Oct 31, 2024
novawallet/Modules/ParitySigner/TransactionQr/ParitySignerTxQrInteractor.swift
Outdated
Show resolved
Hide resolved
ERussel
reviewed
Oct 31, 2024
# Conflicts: # Podfile.lock
ERussel
reviewed
Nov 4, 2024
novawallet/Common/IconRetrieve/KingfisherIconRetrieveOperationFactory.swift
Outdated
Show resolved
Hide resolved
novawallet/Common/IconRetrieve/KingfisherIconRetrieveOperationFactory.swift
Outdated
Show resolved
Hide resolved
novawallet/Common/QRCreation/Logo/QRWithLogoCreationOperation.swift
Outdated
Show resolved
Hide resolved
novawallet/Common/QRCreation/Logo/QRWithLogoCreationOperation.swift
Outdated
Show resolved
Hide resolved
novawallet/Modules/ParitySigner/TransactionQr/ParitySignerTxQrViewController.swift
Outdated
Show resolved
Hide resolved
ERussel
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AssetReceivescreenQRCodeFactoryto create QR codes and manage cache logicAssetIconURLFactoryto create asset icon URLs based on the selected icon appearanceQRCreationOperationto support logo embedding