fix: rename root keys to seed keys in ui #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldsteinsveta
approved these changes
Apr 25, 2022
|
/parity-signer/android/app/src/main/java/io/parity/signer/components/KeyCard.kt has a mention of root keys in comments. should be seed keys |
Slesarew
added a commit
that referenced
this pull request
Apr 25, 2022
* docs: Update FAQ.md (#1004) * Update FAQ.md * Update FAQ.md edit import derived keys * edit ledger keys * grammar typo Co-authored-by: Slesarew <33295157+Slesarew@users.noreply.github.com> * Adjusted Docker file and sign_android.sh to be build and signe android signer.apk (#1008) * updated docker file and sign_android.sh * adjusted docker file for android builds * refactor: best practices for Docker conatainer Co-authored-by: TriplEight <denis.pisarev@parity.io> * ci: remove old semantic app; add new GHA (#1010) Co-authored-by: Slesarew <33295157+Slesarew@users.noreply.github.com> * fix: rename root keys to seed keys in ui (#1006) * fix: rename root keys to seed keys in ui * fix: rename root key into seed key in error texts (#1007) Co-authored-by: varovainen <99664267+varovainen@users.noreply.github.com> * chore: kusama9190 into release metadata Co-authored-by: goldsteinsveta <sveta@parity.io> Co-authored-by: Slesarew <33295157+Slesarew@users.noreply.github.com> Co-authored-by: Egor_P <egor@parity.io> Co-authored-by: TriplEight <denis.pisarev@parity.io>
EgorPopelyaev
added a commit
that referenced
this pull request
May 11, 2022
* chore: update westend and remove hot side db from git * chore: gitignore hot database * chore: kusama9190 update (#1013) * docs: Update FAQ.md (#1004) * Update FAQ.md * Update FAQ.md edit import derived keys * edit ledger keys * grammar typo Co-authored-by: Slesarew <33295157+Slesarew@users.noreply.github.com> * Adjusted Docker file and sign_android.sh to be build and signe android signer.apk (#1008) * updated docker file and sign_android.sh * adjusted docker file for android builds * refactor: best practices for Docker conatainer Co-authored-by: TriplEight <denis.pisarev@parity.io> * ci: remove old semantic app; add new GHA (#1010) Co-authored-by: Slesarew <33295157+Slesarew@users.noreply.github.com> * fix: rename root keys to seed keys in ui (#1006) * fix: rename root keys to seed keys in ui * fix: rename root key into seed key in error texts (#1007) Co-authored-by: varovainen <99664267+varovainen@users.noreply.github.com> * chore: kusama9190 into release metadata Co-authored-by: goldsteinsveta <sveta@parity.io> Co-authored-by: Slesarew <33295157+Slesarew@users.noreply.github.com> Co-authored-by: Egor_P <egor@parity.io> Co-authored-by: TriplEight <denis.pisarev@parity.io> * chore: westend9200 update (#1015) * chore: kusama9190 into release metadata * chore: westend9200 update * chore: westend9201 update (#1026) * chore: polkadot9190 update (#1028) Co-authored-by: varovainen <99664267+varovainen@users.noreply.github.com> Co-authored-by: goldsteinsveta <sveta@parity.io> Co-authored-by: Egor_P <egor@parity.io> Co-authored-by: TriplEight <denis.pisarev@parity.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will need to fix this in internal code as well later, after ongoing large refactor #999