Refactor updateNewAccount #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanwencheng
approved these changes
Jul 25, 2019
|
LGTM |
hanwencheng
reviewed
Jul 25, 2019
|
@Tbaut tested on iphone 6, works as expected! |
|
|
pmespresso
approved these changes
Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
debounceWhat it effectively solves:
On account recovery, debounce is working, the device used to calculate the address at every key stroke. Now it's effectively debouncing (after/before):
On new account, the icon selection doesn't re-render.
I do exactly the same in each example, I click on new account and click on the 4 first icons consecutively. You can see the selection is jumping. (before/after)