chore: renaming to seedPhrase when phrase is used #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanwencheng
commented
Nov 26, 2019
| @@ -296,6 +296,8 @@ export default class AccountsStore extends Container<AccountsStoreState> { | |||
|
|
|||
| async saveNewIdentity(seedPhrase, pin) { | |||
| const updatedIdentity = deepCopyIdentity(this.state.newIdentity); | |||
| //TODO encrypt seedPhrase with password in the future version, | |||
| // current encryption with only seedPhrase is compatible. | |||
| updatedIdentity.encryptedSeed = await encryptData(seedPhrase, pin); | |||
There was a problem hiding this comment.
Currently we only encrypt seedPhrase in encryptedSeed, but will include password in the future
hanwencheng
commented
Nov 26, 2019
| @@ -38,7 +38,8 @@ type AccountMeta = { | |||
| }; | |||
|
|
|||
| export type Identity = { | |||
| encryptedSeedPhrase: string, | |||
| // encrypted seed include seedPhrase and password | |||
There was a problem hiding this comment.
currently only seedPhrase
hanwencheng
changed the title
pmespresso
reviewed
Nov 26, 2019
| @@ -45,6 +45,7 @@ build/ | |||
| .gradle | |||
| local.properties | |||
| *.iml | |||
| gen/ | |||
There was a problem hiding this comment.
just curious, what is generating this?
There was a problem hiding this comment.
I don't know either, after build android with gradle assemble, it created three files under gen: buildConfig.java, Manifest.java and R.java. On each of them there is a head comment said:
/*___Generated_by_IDEA___*/
So I just add them there.
sjeohp-zz
approved these changes
Nov 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Naming is the most difficult problem.
Renaming
seedtoseedPhraseif phrase is used.In schema we use
encryptedSeedsince password will also used to secure that in the future version.