-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrating to typescript #521
Conversation
jest.config.js
Outdated
@@ -14,14 +14,30 @@ | |||
// You should have received a copy of the GNU General Public License | |||
// along with Parity. If not, see <http://www.gnu.org/licenses/>. | |||
|
|||
const { defaults } = require('jest-config'); | |||
// const { defaults } = require('jest-config'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit found while skimming it: stray comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch! also deleted other console.log
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ts config looks fine, haven't done a full test yet though.
Testing on iOS.
|
Re @sjeohp , thanks for checking it!
|
closes #418.
Include update to React Navigation v4.
This PR I avoid to make changes to all the functionalities and UI features.
But may need to test all the signing issues.
Other changes includes:
components
,screens
,styles
,constants
,utils
,stores
,types
>=10
because of dev dependencyfsevents