Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

major: load Network from Context, enable adding Network from QR #681

Merged
merged 11 commits into from
Sep 2, 2020

Conversation

hanwencheng
Copy link
Contributor

@hanwencheng hanwencheng commented Aug 31, 2020

closes #302 closes #406

This PR enables adding new network / update existing network to Parity Signer via QR code

it Includes:

  1. Save added / updated network into app storage.
  2. Reafactor state management and use dynamic networks.
  3. Add e2e test for adding new network and signing extrinsic on new network.
  4. new tutorials on how to use this feature.

How to Test

1. Get the network metadata as QR Code

Switch to the network you want to play with on Polkadot.js app. Click Settings -> MetaData

Screen Shot 2020-09-01 at 17 26 10

Here we can see the chain specifications like Network Name, Address Prefix, and Genesis Hash etc. They are all the metaData of the network which is required by Parity Signer. The only item we could change is network color, it is used on Parity Signer to distinguish other networks.

On the right side is the QR Code we need.

2. Scan metadata QR code with Parity Signer

Now on the Parity Signer app, click the QR scanner Button anywhere on the app, and scan this QR code, you will have the new Network added to Parity Signer. You can now create accounts under it and sign extrinsic with this network.

Screen Shot 2020-09-01 at 17 36 40

Notice since the metadata is generally very big data, and currently, it is hard to sync with Parity Signer, so when signing the transactions on added networks, we cannot interpreter the extrinsic details at the moment. Please check on this issue for the update.

@hanwencheng hanwencheng changed the title major: load Network from Context, enable adding Network from QR WIP: major: load Network from Context, enable adding Network from QR Aug 31, 2020
@hanwencheng hanwencheng changed the title WIP: major: load Network from Context, enable adding Network from QR major: load Network from Context, enable adding Network from QR Sep 1, 2020
@hanwencheng hanwencheng merged commit 29bcf80 into master Sep 2, 2020
@hanwencheng hanwencheng deleted the hanwen-store-network-data branch September 2, 2020 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manage network screen Add network with QR scan
1 participant