feat: backend: generate_message warns if metadata seems useless #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prybalko
approved these changes
Jan 29, 2022
rust/definitions/src/metadata.rs
Outdated
| /// signed extensions into Signer. | ||
| /// This function should be used for warnings only on generate_message side and during metadata | ||
| /// loading into Signer. | ||
| fn v14_warn (metadata_v14: &RuntimeMetadataV14) -> bool { |
There was a problem hiding this comment.
Looking at the function name only, it's not obvious that it returns bool. Maybe is_v14_signed or is_v14_ok would be a better option
There was a problem hiding this comment.
Changed this below and also used hashmap to catch duplicates of extensions (paranoid but important!); please have another look
prybalko
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small but useful feature: warning if metadata could not really be used to parse signable transactions due to incomplete extensions set