Add new url property usage description. #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcavar
reviewed
May 15, 2018
README.md
Outdated
| @@ -73,6 +73,18 @@ Publish a message to a topic: | |||
| }]; | |||
| ``` | |||
|
|
|||
| If you already have a self signed URL from broker like AWS IoT endpoint, use the url property of MQTTWebsocketTransport: | |||
There was a problem hiding this comment.
Can we put MQTTWebsocketTransport in backquotes?
jcavar
reviewed
May 15, 2018
README.md
Outdated
| MQTTSession *session = [[MQTTSession alloc] init]; | ||
| session.transport = transport; | ||
| [session connectWithConnectHandler:^(NSError *error) { | ||
| // Do some work |
There was a problem hiding this comment.
Oops. Sorry missed this one.
|
@jcavar took care of comments. |
|
Nice! Thank you @mendirattanishant! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #461 we introduced new property
urlinMQTTWebsocketTransportto accept custom pre signed url for connection.