Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update table_to_json to be compatible with C++ 20 #16

Merged
merged 2 commits into from
Nov 20, 2022
Merged

Update table_to_json to be compatible with C++ 20 #16

merged 2 commits into from
Nov 20, 2022

Conversation

Pheubel
Copy link

@Pheubel Pheubel commented Nov 19, 2022 •
edited
Loading

this pr would close #14 and by extend partially resolves novelrt/NovelRT#500

RubyNova
RubyNova approved these changes Nov 20, 2022
View reviewed changes
Copy link
Member

@RubyNova RubyNova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Monica is on holiday right now so I'll just merge this

@RubyNova RubyNova merged commit 01c5804 into novelrt:feature/runtime Nov 20, 2022
@Pheubel Pheubel mentioned this pull request Nov 25, 2022
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RubyNova RubyNova RubyNova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pheubel @RubyNova