-
Notifications
You must be signed in to change notification settings - Fork 29
Upgrade Gradle to 5.1.1 #168
Comments
@zegnus, I can verify that it works fine with Gradle 5.x. Since we don't use any of internal APIs, it should always be backward compatible. I have an open PR #165 where I try to integrate lazy task configuration from Gradle 5 in a backward compatible fashion. We will definitely upgrade to 5.1.1 together with that. There is no practicle reason to update now. Having said that, feel free to open a PR for the upgrade. 🙌 |
I cannot open a PR for this upgrade because the sample applications fail: In then, inside the
It fails with the following:
|
I thought I've been using it with 5.1.1 but I don't have checkstyle integrated. So something is wrong with checkstyle then. I will have a look. |
This is the line that seems to break:
|
I've seen that Gradle team had a fix for checkstyle on 5.2. Can you double check with that version? Thanks |
Checked with |
Tried with 5.2.1 and Java 8 (below 8 not supported) and it assembles correctly.
It seems to be having a memory issues as that error comes after an OOM Exception. The sample test directory runs correctly when manually run from command line (after adding the version to the dependencies), so we think it may be related to |
Thanks @pablisco We can update the Gradle version in a PR and see what CI says. You are describing how you try to build the project. What about using the latest stable version with Gradle 5.2.1 in a project? |
Looking at updating this project to work with 5.x first.
|
@tasomaniac These are the changes I've tried so far if you want to try them locally: |
Ok, I started to take a look at this myself. I have pushed some changes to |
I quickly tried to use the latest snapshot on a project using Gradle 5.2.1 and found an issue. A PR with a fix is open: #179. |
With #180 we should have a snapshot that works correctly with projects running with Gradle 5.x I have tried the snapshot on the samples and on another app using Gradle 5.x with success. This means that we will not have any urgent need to migrate the plugin to compile against Gradle 5.x as we are not using any more deprecated API or similar. |
The issue with Gradle 5.x and I'll kip this issue open to track the conversation around the |
Hi All, |
This is finally done as part of #203 |
The current used version is 4.10.2 https://github.com/novoda/gradle-static-analysis-plugin/blob/master/sample-multi-module/gradle/wrapper/gradle-wrapper.properties#L3
It would be great to ensure that the plugin supports the latest 5.x available Gradle version, including the sample applications.
The text was updated successfully, but these errors were encountered: