This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Fix Findbugs configuration (part 2) #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The fix shipped in #174 apparently wasn't good enough because when
classesDirscontains more than one dir in it then we face a problem where theFileTree.plus()produces aUnionFileTreethat is not confirming to some of the interfaces we need.Solution
Similarly to what done #179 we can just apply
include()to the subtree created for each entry inclassesDirs.Incidentally I have upgraded the 2 sample apps to use Gradle 5.x as a way to validate the fix is working, while we still are facing issues running the functional tests in
:pluginwith Gradle 5.x.