This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Add sample application #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with sample setup
Configure detekt using the gradle plugins repo
mr-archano
reviewed
Mar 13, 2018
There was a problem hiding this comment.
Thanks for this @takecare. I left a minor question, LGTM otherwise.
|
|
||
| <suppressions> | ||
|
|
||
| <suppress checks=".*" files=".*\.kt" /> |
There was a problem hiding this comment.
wouldn't be enough to have this setting in the buildscript using the checkstyle.exclude()?
There was a problem hiding this comment.
indeed. and it's another plugin functionality being showcased.
to showcase different ways of ignoring/excluding tests
and fix pmd rule set import
rock3r
previously approved these changes
Mar 14, 2018
There was a problem hiding this comment.
Nice — I would've put a mention to the sample in the repos/documentation though (and, possibly, some mention in the sample's own readme of how the Novoda scaffolding works)
sample/app/build.gradle
Outdated
| buildToolsVersion '27.0.3' | ||
|
|
||
| defaultConfig { | ||
| applicationId "com.novoda.staticanalysis.sample" |
There was a problem hiding this comment.
Nit: single quotes here and for the versionName
sample/build.gradle
Outdated
| @@ -0,0 +1,20 @@ | |||
| buildscript { | |||
| ext.kotlin_version = '1.2.21' | |||
mr-archano
approved these changes
Mar 14, 2018
|
@mr-archano yup, i'll open another pr for the multi-module setup later |
|
Ok let's 🚢 then! Thanks @takecare :) |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a sample app showcasing the usage of the plugin and some of its features. The inclusion of
detektmight be particularly interesting since its setup is not straightforward.Should cover #95