This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Release v0.4 #29
Merged
Release v0.4 #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frapontillo
suggested changes
Feb 22, 2017
README.md
Outdated
| @@ -128,5 +142,5 @@ Tool | Android | Java | Documentation | | |||
|
|
|||
| #### Support for sharable configurations | |||
|
|
|||
| We plan to add support for consuming rules (eg: configuration files for Checkstyle or PMD, default exclude filters, etc) via a | |||
| The plugin can consume rules (eg: configuration files for Checkstyle or PMD, default exclude filters, etc) via a | |||
| separate artifact you can share across projects. _More info to come._ | |||
There was a problem hiding this comment.
Is "more info to come" still valid?
There was a problem hiding this comment.
Not sure. I'd like to expand this with an example, but we have no publicly deployed artifact for shared rules yet, hence the More info to come still there.
There was a problem hiding this comment.
Maybe remove it until we have info?
There was a problem hiding this comment.
I'm happy to leave it then. It just reads as if the feature isn't implemented, which it is.
There was a problem hiding this comment.
Good point guys. I'll get rid of it.
ataulm
approved these changes
Feb 22, 2017
ouchadam
approved these changes
Feb 22, 2017
|
leaving to @frapontillo |
frapontillo
approved these changes
Feb 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of the PR
We want to release a new version of the plugin on Novoda Bintray maven repo, to ship the changes from #27, #28 and #25.
Considerations and implementation
READMECHANGELOG