This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 29
[PT-507] Release 0.5 #63
Merged
Merged
Changes from all commits
Commits
Show all changes
168 commits
Select commit
Hold shift + click to select a range
135bd18
Update Gradle to 4.3.1
rock3r 567a529
Prefer implementation over compile
rock3r eca7cef
Use newer SDK and Android plugin for compatibility with Gradle 4.3
rock3r c3834c1
Fix root directory heuristics
rock3r 1ce7985
Add dimension to all test project flavours
rock3r 8541f7a
Remove withDebug(true) when running test projects because of class lo…
mr-archano b2cb361
Update assertions to check for the right task outcome state
mr-archano cb74c30
Merge pull request #37 from novoda/update_gradle
mr-archano b808fd3
Restructure fixtures directory to just bundle the rules
tobiasheine e00ffb0
Merge branch 'develop' into PT-273/restructure_fixtures
tobiasheine 6aaca1a
Merge pull request #41 from novoda/PT-273/restructure_fixtures
mr-archano b20c7e3
Avoid to create Violations from evaluation task for Checkstyle config…
mr-archano 1d2ab5e
Avoid to create Violations from evaluation task for PMD configurator
mr-archano a520607
Avoid to create Violations from evaluation task for Findbugs configur…
mr-archano 4e8cea0
Remove factory method from task
mr-archano 6fd65be
Add more convenience methods to plugin extension
mr-archano c0a84d9
Introduce delegate to evaluate violations
mr-archano 8aaa71b
Avoid usage of specific type of task
mr-archano 68713d4
Add mockito dependency
mr-archano e88d5e3
Test default evaluator class
mr-archano e59963b
Rearrange evaluator API and internals to avoid direct usage of plugin…
mr-archano 7477d22
Make evaluation task to use evaluator delegate
mr-archano e38ff5e
Update strings in assertion subject to match updated logs
mr-archano ec5a8e0
Define value type holding input for evaluator
mr-archano 7cce8db
Rename property in input type
mr-archano 160f9d9
Remove unused Project instance in test
mr-archano e20b2e6
Provide facility to define custom evaluation logic
mr-archano 4943dca
Remove Input type from evaluator
mr-archano a1f4340
Adjust penalty extension configuration
mr-archano bdb0e82
Simplify loop in default evaluator
mr-archano 717268d
Merge pull request #45 from novoda/feature/42/remove_convention_mapping
tasomaniac ee20ebf
Add TestKotlinProject to setup a test kotlin project
tobiasheine 26b52d4
Support multiple plugins for test projects
tobiasheine 1aa8d83
Add detekt kotlin fixtures
tobiasheine 6bb5a1f
Expose kotlin test project rule
tobiasheine 9d7b9d1
Add kotlin support to TestKotlinProject
tobiasheine 3c03ba4
Expose projectDir to configure an output dir for detekt used in the t…
tobiasheine a87451e
Add DetektIntegrationTest which verifies the build fails when detekt …
tobiasheine 54f982b
Simplify Warning Fixture
tobiasheine e1d1512
Add skeleton for DetektConfigurator
tobiasheine 44c2b08
Add detekt to test project classpath
tobiasheine 913a6e7
Apply detekt plugin in case the project has kotlin configured
tobiasheine 5b775fe
Apply detekt configuration to the detekt extension
tobiasheine 432bc1f
Fix broken Fixture path
tobiasheine b00ed49
Add empty line to fixture file in order to suppress not wanted detekt…
tobiasheine 3903089
Add CollectDetektViolationsTask
tobiasheine fdd3756
Configure detekt task to collect violations
tobiasheine f5c85ca
Revert Fixture path change
tobiasheine c61e8e2
Link detekt report file to CollectDetektViolationsTask
tobiasheine c9af099
Remove not needed public keyword
tobiasheine eea5b69
Extract common Configurator interface
tobiasheine 0bc714d
Create DetektConfigurator as part of other Configurators
tobiasheine 9b4cf95
Add a test case to verify the the build fails when detekt errors are …
tobiasheine 1b2a154
Verify the build does not fail in case detekt is not configured or th…
tobiasheine 5b52771
Should not fail when no warnings or errors threshold trespassed
tobiasheine 9249690
Remove empty line
tobiasheine faee71d
Rename field
tobiasheine 7a82512
Rename class
tobiasheine 4030061
Simplify task access
tobiasheine 64405bb
Fix wrong generic type
tobiasheine 70b7b2f
Add comment which might be useful for other developers
tobiasheine fd34d6b
Improve test names
tobiasheine 584c716
Remove extra white line
tobiasheine 794b74c
Fix format
tobiasheine 0f87c44
Merge pull request #46 from novoda/PT-494/support_plain_kotlin_projects
tasomaniac c0f6eba
Support versions for adding a plugin
tobiasheine c573067
Do not apply detekt for each kotlin test project
tobiasheine 0402b1a
Apply detekt plugin manually in tests
tobiasheine c27b3af
Do not apply detekt as part of our plugin since we expect the user to…
tobiasheine 1b6b9c6
Add a test which verifies we inform the user to manually apply detekt…
tobiasheine b2e0a09
Throw an exception in case the detekt plugin is configured but not ap…
tobiasheine 81a87eb
Fix typo
tobiasheine d9b1812
Use default parameter instead of passing null
tobiasheine d45e5a3
Check for the plugin rather than for a task
tobiasheine 8ba85d1
Inline method
tobiasheine 2ecbc1a
Extract detektConfiguration to improve test readability
tobiasheine 8cd6c1b
Extract configuration to improve readability
tobiasheine 71b32c5
Refer to detekt dokumentation on how to apply the plugin
tobiasheine e708ab5
Merge pull request #47 from novoda/PT-498/expect_the_user_to_configur…
tasomaniac 4292d6b
Create TestAndroidKotlin project which can be used to verify the dete…
tobiasheine 0f36aa9
Verify all tests are working as well for a android project using kotlin
tobiasheine a8a3f52
Name the source set folder to kotklin since it's a kotlin project
tobiasheine f717db0
Change label for android kotlin test project
tobiasheine 72bd9fa
Remove nasty whitespaces
tobiasheine 3eed973
Merge pull request #48 from novoda/PT-495/support_android_kotlin_proj…
tasomaniac 0d734d0
Use relative path with project dir to link detekt reports
tobiasheine 4eb544e
Make htmlReportFile configurable since detekt names it different than…
tobiasheine 9e7061a
Link to correct detekt html report
tobiasheine 318fb79
Use getter since we now have a field for the htmlReportFile
tobiasheine 1277aef
Merge pull request #49 from novoda/PT-503/detekt_reports_are_not_pick…
tasomaniac 3e91310
Improve readme file
rock3r d453d9c
Fix Apache 2.0 licence
rock3r 21d3533
Move non-essential content out of the readme
rock3r 8cf0a9e
Clarify supported tools table in README
rock3r dfc590a
Reorganise advanced-usage contents
rock3r 8930952
Add TOC to advanced-usage
rock3r 691c20d
Create supported-tools
rock3r accf4fc
Simplify README, point to pages in docs/
rock3r 7c43d55
Add missing whiteline at EOF in NOTICE
rock3r d4c6ef0
Fix Android Lint support matrix
rock3r ce97e86
Add documentation for the Checkstyle plugin
rock3r 1b32738
Add instructions for enabling/disabling tools
rock3r e0e5ff4
Use defaults in config in the README file
rock3r 40cba31
Tweak Detekt missing exception message
rock3r 4696307
Update Missing Detekt message in tests
rock3r 0577d74
Add documentation for all tools to supported-tools
rock3r 9cc5780
Fix typo
tasomaniac 4160752
Merge pull request #53 from novoda/tweak-detekt-exception-message
tasomaniac f7074d1
Merge branch 'PT-491/integrate_detekt' into add_detekt_and_reorganise…
rock3r fb10e7f
Fix grammar in error message
rock3r f0d2803
Cleanup DetektConfigurator
rock3r 2a02420
Cleanup LogsSubject
rock3r 267b4bf
Merge pull request #57 from novoda/tweak-detekt-exception-message
mr-archano f9b8f07
Shorten a title in README
rock3r cb7a7d4
Remove "Kotlin" from a title in README
rock3r 21430dc
Note that excludes don't work for Detekt
rock3r a38c70b
Note not to configure limits or failFast for Detekt
rock3r b6e2e1e
Explain how to exclude files from Detekt analysis
rock3r fadaac3
Tweak wording for adding Detekt to a project
rock3r 0458a77
Merge pull request #54 from novoda/add_detekt_and_reorganise_readme
tasomaniac 986bae9
Merge pull request #58 from novoda/PT-491/integrate_detekt
rock3r 80719f7
Split out tool docs into separate files in tools/
rock3r 80a90bc
Add warning and error fixture for android lint
tobiasheine 536d441
Remove not needed deploy test rule since we do not deploy the rules t…
tobiasheine ecfb0d8
Link lint fixtures
tobiasheine 431e131
Verify the build should fail when lint warnings over threshold
tobiasheine f1a44a9
Remove not needed TestRule since we android lint just supports androi…
tobiasheine 83bb9e1
Add lint sample report fixture
tobiasheine cc50e0d
Verify we collect lint violations from the lint sample report
tobiasheine 89db271
Configure lint via plugin extension
tobiasheine 6532dd6
Do not exclude lint for android projects
tobiasheine cb13b2b
Lint expects link to file instead of path as string
tobiasheine be97273
Bump build tool version to suppress unwanted lint warning
tobiasheine b5ce20a
Resolve report directory manually
tobiasheine 495897b
Apply lint test rule
tobiasheine 98d9c04
Revert "Bump build tool version to suppress unwanted lint warning"
tobiasheine 19ed465
Ignore GradleDependency warning to keep the test stable
tobiasheine 0f742bd
Remove not needed comment
tobiasheine f981723
Fix typo
tobiasheine 85cea37
Parse lint xml result and append errors and warnings to Violations
tobiasheine a43b9e0
Add static import for Truth.assertThat
tobiasheine 9a97864
Verify the build passes when warnings within thresholds
tobiasheine da00fed
Verify the html report is linked in the log
tobiasheine b2c0f72
Verify the build fails when errors over thresholds
tobiasheine 92f90d9
Verify the build does not fail when erros within thresholds
tobiasheine f99d0ba
Simplify lint configuration
tobiasheine 7f0e764
Remove empty line
tobiasheine 7bd712b
Use single quotes
tobiasheine d10f0d3
Use single quoted string
tobiasheine 7302801
Extract constant for lint configuration
tobiasheine db6bb78
Force xml report and not to fail on any error
tobiasheine c084622
Force html report since we link it
tobiasheine ef87810
Use configured xml output file or fall back to hardcoded one
tobiasheine 1411643
Use a getter
tobiasheine a3ef319
Use project.buildDir rather than building it manually
tobiasheine f1939a0
Fix link text in advanced-usage
rock3r 7345955
Merge pull request #59 from novoda/separate_tools_docs
tobiasheine 8847529
Merge branch 'develop' into PT-282/integrate_android_lint
tobiasheine 2fcb248
Add lint configuration to readme
tobiasheine d3c7246
Tweak android lint readme
tobiasheine 56ea31b
Add a warning regarding missing kotlin support for lint
tobiasheine 0cb9763
Fix wrong version
tobiasheine 6f0bfc7
Fix typo
tobiasheine 8b1d1cf
Tweak lint documentation
tobiasheine 3dc3167
Merge pull request #61 from novoda/PT-518/add_lint_config_to_readme
tasomaniac b29899c
Merge pull request #62 from novoda/PT-282/integrate_android_lint
rock3r 523223d
Bump version to 0.5
tobiasheine 6c928da
Add Detekt and Android Lint to Change Log
tobiasheine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,177 @@ | ||
|
||
Apache License | ||
Version 2.0, January 2004 | ||
http://www.apache.org/licenses/ | ||
|
||
TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION | ||
|
||
1. Definitions. | ||
|
||
"License" shall mean the terms and conditions for use, reproduction, | ||
and distribution as defined by Sections 1 through 9 of this document. | ||
|
||
"Licensor" shall mean the copyright owner or entity authorized by | ||
the copyright owner that is granting the License. | ||
|
||
"Legal Entity" shall mean the union of the acting entity and all | ||
other entities that control, are controlled by, or are under common | ||
control with that entity. For the purposes of this definition, | ||
"control" means (i) the power, direct or indirect, to cause the | ||
direction or management of such entity, whether by contract or | ||
otherwise, or (ii) ownership of fifty percent (50%) or more of the | ||
outstanding shares, or (iii) beneficial ownership of such entity. | ||
|
||
"You" (or "Your") shall mean an individual or Legal Entity | ||
exercising permissions granted by this License. | ||
|
||
"Source" form shall mean the preferred form for making modifications, | ||
including but not limited to software source code, documentation | ||
source, and configuration files. | ||
|
||
"Object" form shall mean any form resulting from mechanical | ||
transformation or translation of a Source form, including but | ||
not limited to compiled object code, generated documentation, | ||
and conversions to other media types. | ||
|
||
"Work" shall mean the work of authorship, whether in Source or | ||
Object form, made available under the License, as indicated by a | ||
copyright notice that is included in or attached to the work | ||
(an example is provided in the Appendix below). | ||
|
||
"Derivative Works" shall mean any work, whether in Source or Object | ||
form, that is based on (or derived from) the Work and for which the | ||
editorial revisions, annotations, elaborations, or other modifications | ||
represent, as a whole, an original work of authorship. For the purposes | ||
of this License, Derivative Works shall not include works that remain | ||
separable from, or merely link (or bind by name) to the interfaces of, | ||
the Work and Derivative Works thereof. | ||
|
||
"Contribution" shall mean any work of authorship, including | ||
the original version of the Work and any modifications or additions | ||
to that Work or Derivative Works thereof, that is intentionally | ||
submitted to Licensor for inclusion in the Work by the copyright owner | ||
or by an individual or Legal Entity authorized to submit on behalf of | ||
the copyright owner. For the purposes of this definition, "submitted" | ||
means any form of electronic, verbal, or written communication sent | ||
to the Licensor or its representatives, including but not limited to | ||
communication on electronic mailing lists, source code control systems, | ||
and issue tracking systems that are managed by, or on behalf of, the | ||
Licensor for the purpose of discussing and improving the Work, but | ||
excluding communication that is conspicuously marked or otherwise | ||
designated in writing by the copyright owner as "Not a Contribution." | ||
|
||
"Contributor" shall mean Licensor and any individual or Legal Entity | ||
on behalf of whom a Contribution has been received by Licensor and | ||
subsequently incorporated within the Work. | ||
|
||
2. Grant of Copyright License. Subject to the terms and conditions of | ||
this License, each Contributor hereby grants to You a perpetual, | ||
worldwide, non-exclusive, no-charge, royalty-free, irrevocable | ||
copyright license to reproduce, prepare Derivative Works of, | ||
publicly display, publicly perform, sublicense, and distribute the | ||
Work and such Derivative Works in Source or Object form. | ||
|
||
3. Grant of Patent License. Subject to the terms and conditions of | ||
this License, each Contributor hereby grants to You a perpetual, | ||
worldwide, non-exclusive, no-charge, royalty-free, irrevocable | ||
(except as stated in this section) patent license to make, have made, | ||
use, offer to sell, sell, import, and otherwise transfer the Work, | ||
where such license applies only to those patent claims licensable | ||
by such Contributor that are necessarily infringed by their | ||
Contribution(s) alone or by combination of their Contribution(s) | ||
with the Work to which such Contribution(s) was submitted. If You | ||
institute patent litigation against any entity (including a | ||
cross-claim or counterclaim in a lawsuit) alleging that the Work | ||
or a Contribution incorporated within the Work constitutes direct | ||
or contributory patent infringement, then any patent licenses | ||
granted to You under this License for that Work shall terminate | ||
as of the date such litigation is filed. | ||
|
||
4. Redistribution. You may reproduce and distribute copies of the | ||
Work or Derivative Works thereof in any medium, with or without | ||
modifications, and in Source or Object form, provided that You | ||
meet the following conditions: | ||
|
||
(a) You must give any other recipients of the Work or | ||
Derivative Works a copy of this License; and | ||
|
||
(b) You must cause any modified files to carry prominent notices | ||
stating that You changed the files; and | ||
|
||
(c) You must retain, in the Source form of any Derivative Works | ||
that You distribute, all copyright, patent, trademark, and | ||
attribution notices from the Source form of the Work, | ||
excluding those notices that do not pertain to any part of | ||
the Derivative Works; and | ||
|
||
(d) If the Work includes a "NOTICE" text file as part of its | ||
distribution, then any Derivative Works that You distribute must | ||
include a readable copy of the attribution notices contained | ||
within such NOTICE file, excluding those notices that do not | ||
pertain to any part of the Derivative Works, in at least one | ||
of the following places: within a NOTICE text file distributed | ||
as part of the Derivative Works; within the Source form or | ||
documentation, if provided along with the Derivative Works; or, | ||
within a display generated by the Derivative Works, if and | ||
wherever such third-party notices normally appear. The contents | ||
of the NOTICE file are for informational purposes only and | ||
do not modify the License. You may add Your own attribution | ||
notices within Derivative Works that You distribute, alongside | ||
or as an addendum to the NOTICE text from the Work, provided | ||
that such additional attribution notices cannot be construed | ||
as modifying the License. | ||
|
||
You may add Your own copyright statement to Your modifications and | ||
may provide additional or different license terms and conditions | ||
for use, reproduction, or distribution of Your modifications, or | ||
for any such Derivative Works as a whole, provided Your use, | ||
reproduction, and distribution of the Work otherwise complies with | ||
the conditions stated in this License. | ||
|
||
5. Submission of Contributions. Unless You explicitly state otherwise, | ||
any Contribution intentionally submitted for inclusion in the Work | ||
by You to the Licensor shall be under the terms and conditions of | ||
this License, without any additional terms or conditions. | ||
Notwithstanding the above, nothing herein shall supersede or modify | ||
the terms of any separate license agreement you may have executed | ||
with Licensor regarding such Contributions. | ||
|
||
6. Trademarks. This License does not grant permission to use the trade | ||
names, trademarks, service marks, or product names of the Licensor, | ||
except as required for reasonable and customary use in describing the | ||
origin of the Work and reproducing the content of the NOTICE file. | ||
|
||
7. Disclaimer of Warranty. Unless required by applicable law or | ||
agreed to in writing, Licensor provides the Work (and each | ||
Contributor provides its Contributions) on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or | ||
implied, including, without limitation, any warranties or conditions | ||
of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A | ||
PARTICULAR PURPOSE. You are solely responsible for determining the | ||
appropriateness of using or redistributing the Work and assume any | ||
risks associated with Your exercise of permissions under this License. | ||
|
||
8. Limitation of Liability. In no event and under no legal theory, | ||
whether in tort (including negligence), contract, or otherwise, | ||
unless required by applicable law (such as deliberate and grossly | ||
negligent acts) or agreed to in writing, shall any Contributor be | ||
liable to You for damages, including any direct, indirect, special, | ||
incidental, or consequential damages of any character arising as a | ||
result of this License or out of the use or inability to use the | ||
Work (including but not limited to damages for loss of goodwill, | ||
work stoppage, computer failure or malfunction, or any and all | ||
other commercial damages or losses), even if such Contributor | ||
has been advised of the possibility of such damages. | ||
|
||
9. Accepting Warranty or Additional Liability. While redistributing | ||
the Work or Derivative Works thereof, You may choose to offer, | ||
and charge a fee for, acceptance of support, warranty, indemnity, | ||
or other liability obligations and/or rights consistent with this | ||
License. However, in accepting such obligations, You may act only | ||
on Your own behalf and on Your sole responsibility, not on behalf | ||
of any other Contributor, and only if You agree to indemnify, | ||
defend, and hold each Contributor harmless for any liability | ||
incurred by, or claims asserted against, such Contributor by reason | ||
of your accepting any such warranty or additional liability. | ||
|
||
END OF TERMS AND CONDITIONS |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link doesn't work yet. The
publishRelease
triggered by the CI will create the tag.