This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
[PT-523] - Move Violations out of the internal package #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasomaniac
reviewed
Feb 1, 2018
| @@ -1,7 +1,7 @@ | |||
| package com.novoda.staticanalysis.internal.pmd | |||
|
|
|||
| import com.novoda.staticanalysis.internal.CollectViolationsTask | |||
| import com.novoda.staticanalysis.internal.Violations | |||
| import com.novoda.staticanalysis.Violations | |||
There was a problem hiding this comment.
Can you re-format all the files, I believe this import should come first.
There was a problem hiding this comment.
Such an eagle 👁
tasomaniac
previously approved these changes
Feb 1, 2018
tasomaniac
approved these changes
Feb 1, 2018
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PT-523
Description
With version 0.5
Violationsare part of the public API, but they're still located in theinternalpackage. Click here for more details.