This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
Select Audio Track #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 6, 2017 14:17
ouchadam
reviewed
Apr 7, 2017
| @@ -27,6 +29,10 @@ | |||
|
|
|||
| void attach(PlayerView playerView); | |||
|
|
|||
| void setAudioTrack(int audioTrackIndex); | |||
There was a problem hiding this comment.
this is more of a selectAudioTrack(index) than a set
|
nice work! just the comment about a method name, otherwise LGMT 👍 |
ouchadam
approved these changes
Apr 7, 2017
| return audioTracks; | ||
| } | ||
|
|
||
| public void setAudioTrack(int audioTrackIndex) { |
There was a problem hiding this comment.
same as the other? select
|
Same as @ouchadam ; |
|
Amended in : 3fef8ed Also found one more thing 🙈 . 3fef8ed#diff-379a1e7be0f368e89f56122346e736a4R443 it should be |
juankysoriano
approved these changes
Apr 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Clients of
no-playerare unable to select theaudio trackthey desire at any point during video playback.Solution
Expose methods in the
Playerto allow clients to get a list ofPlayerAudioTrack.PlayAudioTrackconsists of basic info around aMediaFormatsuch aslanguage,channels,mimeTypeetc. To set anAudioTrackthe client needs to specify an index from thePlayerAudioTrackthat matches the audio track they desire.mediaPlayer.selectTrack()is only available aboveapilevel 15 so we upped this as well in this PR. It seems impossible to set anaudio trackbefore this.Paired with
@jackSzm