NO-149/SurfaceRequester #150
Conversation
| import java.util.Deque; | ||
| import java.util.LinkedList; | ||
| import java.util.concurrent.TimeUnit; | ||
|
|
There was a problem hiding this comment.
should this class be in this PR?
There was a problem hiding this comment.
Yeah, I would consider to remove it @Mecharyry, just to avoid to ship it in what is effectively a non-related change set.
|
|
||
| public interface SurfaceRequester { | ||
|
|
||
| void requestSurfaceTexture(Callback callback); |
There was a problem hiding this comment.
No need to use texture, right?
| @@ -5,7 +5,7 @@ | |||
| android:layout_height="wrap_content"> | |||
|
|
|||
| <SurfaceView | |||
| android:id="@+id/surface_view" | |||
| android:id="@+id/texture_view" | |||
There was a problem hiding this comment.
shouldn't we keep this as it was?
| @Override | ||
| public void onClick(View v) { | ||
| dialogCreator.showAudioSelectionDialog(); | ||
| if (player == null || !player.isPlaying() || player.getAudioTracks().size() == 0) { | ||
| Toast.makeText(MainActivity.this, "no audio tracks available!", Toast.LENGTH_LONG).show(); |
There was a problem hiding this comment.
The buttons to trigger the dialog are always present, if you tap them before the player is playing then it will throw an IllegalStateException.
| } | ||
| }; | ||
|
|
||
| private final View.OnClickListener showSubtitleSelectionDialog = new View.OnClickListener() { | ||
| @Override | ||
| public void onClick(View v) { | ||
| if (player.getSubtitleTracks().isEmpty()) { | ||
| if (player == null || !player.isPlaying() || player.getSubtitleTracks().isEmpty()) { |
There was a problem hiding this comment.
Same question here (I know that this is a demo, I am just curious)
| @@ -51,7 +51,7 @@ public View getContainerView() { | |||
| } | |||
|
|
|||
| @Override | |||
| public SurfaceHolderRequester getSurfaceHolderRequester() { | |||
| public SurfaceRequester getSurfaceTextureRequester() { | |||
There was a problem hiding this comment.
Do we need to leak texture here? SurfaceRequester should be enough?
There was a problem hiding this comment.
Oh I missed one apparently 🔍
Problem
The current implementation of
NoPlayerrelies upon aSurfaceHolderRequesterto pass aSurfaceHolderto the underlying player. Clients may want to useSurfaceView,TextureViewetc and the underlying player,ExoPlayerspecifically only cares about theSurface.Solution
Switch out the
SurfaceHolderRequesterwith aSurfaceRequesterpassing aSurfaceto the underlying player.Paired with
Nobody.